W3C home > Mailing lists > Public > public-css-archive@w3.org > March 2017

Re: [csswg-drafts] [css-images-4] Editorial: comma is incorrect in syntax graph in 2.3. Gradient Color-Stops

From: Lea Verou via GitHub <sysbot+gh@w3.org>
Date: Wed, 29 Mar 2017 22:35:11 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-290247184-1490826910-sysbot+gh@w3.org>
I just pushed a change that fixes this issue, hopefully without introducing any new ones.

Previous diagram:
![image](https://cloud.githubusercontent.com/assets/175836/24479651/463aac18-14ae-11e7-9215-d559860a9828.png)

New diagram: 
![image](https://cloud.githubusercontent.com/assets/175836/24479658/507472b8-14ae-11e7-8bb3-9c97006066c2.png)

I wonder if @tabatkins can think of a more elegant solution that only has 2 comma tokens instead of 3?

It appears that the grammar was incorrect too:

```
<color-stop-list> =
  [ <linear-color-stop> , <linear-color-hint>? ]# , <linear-color-stop>
```

Note that the `?` applies to `<linear-color-hint>` only, so you could have two consecutive commas and it would still match. I changed it to:

```
<color-stop-list> =
  [ <linear-color-stop> [, <linear-color-hint>]? ]# , <linear-color-stop>
```

-- 
GitHub Notification of comment by LeaVerou
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/976#issuecomment-290247184 using your GitHub account
Received on Wednesday, 29 March 2017 22:35:18 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 19 October 2021 01:30:30 UTC