Re: [csswg-drafts] [css-rhythm] Real sites using the `line-height-step` property

Maybe I am confused, but as far as I can tell this example from https://blog.jxck.io isn't actually demonstrating the need for line-height-step: no line is actually stepped, except the ones that contain the the titles, which would be much better handled with `block-step-size` than this artificial combination of `display:inline-block` and `width: 100%`.


---
PS: Also, if the `lh` unit was implemented, `article p { margin-top: 1lh; margin-bottom: 1lh; }` would work and remove the need for variables in this example.

-- 
GitHub Notification of comment by frivoal
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/1942#issuecomment-351617960 using your GitHub account

Received on Thursday, 14 December 2017 06:08:11 UTC