I agree with jatinder. "drawFocus" suggests that it will always draw something, but that's wrong. The name "drawCustomFocusRing" is even worse since it never draws anything. I think for the method that actually draws, "drawFocusIfNeeded" would be good. For the other method, "needToDrawFocus" sounds good for the non-accessibility functionality. However, if the name ignores the accessibility side effects, we can expect authors to not set the correct path, since a path is not obviously needed. So I suggest we remove the version of the method that uses the current path, forcing authors to provide a Path parameter, and explain in prose what the Path parameter is for. Of course that would mean making this functionality depend on Path, but I think that's OK. This functionality seems less important than drawFocusIfNeeded. There is the possibility that authors will just supply a bogus Path anyway because they don't care about accessibility, but that's possible with any form of this API. Rob -- Jtehsauts tshaei dS,o n" Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu gthot sf oirng iyvoeu rs ihnesa.r"t sS?o Whhei csha iids teoa stiheer :p atroa lsyazye,d 'mYaonu,r "sGients uapr,e tfaokreg iyvoeunr, 'm aotr atnod sgaoy ,h o'mGee.t" uTph eann dt hwea lmka'n? gBoutt uIp waanndt wyeonut thoo mken.o w
Received on Thursday, 9 January 2014 21:03:05 UTC