RE: drawSystemFocusRing and drawCustomFocusRing names are confusing.

I’ve updated the CR with most of the changes we’ve discussed, but haven’t yet touched the L2 spec.

http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas_CR/





From: Richard Schwerdtfeger [mailto:schwer@us.ibm.com]
Sent: Thursday, January 9, 2014 10:10 AM
To: Alexander Surkov; roc@ocallahan.org
Cc: Rik Cabanier (cabanier@adobe.com); Dominic Mazzoni; Jay Munro; Jatinder Mann; Philippe Le Hegaret (plh@w3.org); Canvas
Subject: Re: drawSystemFocusRing and drawCustomFocusRing names are confusing.


Robert, you probably know Rik Cabanier has been developing a change to FF that had drawSystemFocusRing and drawCustomFocusRing. It was agreed that drawCustomFocusRing was confusing and it was moved to Canvas L2 for further discussion. People did not like the drawSystemFocusRing name. Are you OK with drawFocus() instead?

Also, the current editor's draft does not reflect the changes we discussed in the working group. Jatinder would you please provide a link to Robert so that he can see the latest update?

Rich


Rich Schwerdtfeger

[Inactive hide details for Alexander Surkov ---01/09/2014 11:44:37 AM---I think I'm good with drawFocus name but I don't follow]Alexander Surkov ---01/09/2014 11:44:37 AM---I think I'm good with drawFocus name but I don't follow canvas works hard. CC'ing Roc as reviewer of

From: Alexander Surkov <surkov.alexander@gmail.com<mailto:surkov.alexander@gmail.com>>
To: Richard Schwerdtfeger/Austin/IBM@IBMUS
Cc: Dominic Mazzoni <dmazzoni@google.com<mailto:dmazzoni@google.com>>, "Rik Cabanier (cabanier@adobe.com<mailto:cabanier@adobe.com>)" <cabanier@adobe.com<mailto:cabanier@adobe.com>>, Jay Munro <jaymunro@microsoft.com<mailto:jaymunro@microsoft.com>>, Jatinder Mann <jmann@microsoft.com<mailto:jmann@microsoft.com>>, "Philippe Le Hegaret (plh@w3.org<mailto:plh@w3.org>)" <plh@w3.org<mailto:plh@w3.org>>, Canvas <public-canvas-api@w3.org<mailto:public-canvas-api@w3.org>>, roc@ocallahan.org<mailto:roc@ocallahan.org>
Date: 01/09/2014 11:44 AM
Subject: Re: drawSystemFocusRing and drawCustomFocusRing names are confusing.

________________________________



I think I'm good with drawFocus name but I don't follow canvas works hard. CC'ing Roc as reviewer of canvas drawFocus stuff in Mozilla.
Thank you.
Alex.


On Thu, Jan 9, 2014 at 12:36 PM, Richard Schwerdtfeger <schwer@us.ibm.com<mailto:schwer@us.ibm.com>> wrote:
Fine with me. Alex are you ok with that name for the canvas API in FF: drawFocus() vs. drawSystemFocusRing()?

Rich


Rich Schwerdtfeger

[Inactive hide details for Dominic Mazzoni ---01/09/2014 11:21:41 AM---I'd very much support just calling it drawFocus. - Domini]Dominic Mazzoni ---01/09/2014 11:21:41 AM---I'd very much support just calling it drawFocus. - Dominic

From: Dominic Mazzoni <dmazzoni@google.com<mailto:dmazzoni@google.com>>
To: Jatinder Mann <jmann@microsoft.com<mailto:jmann@microsoft.com>>
Cc: Jay Munro <jaymunro@microsoft.com<mailto:jaymunro@microsoft.com>>, "Rik Cabanier (cabanier@adobe.com<mailto:cabanier@adobe.com>)" <cabanier@adobe.com<mailto:cabanier@adobe.com>>, "Philippe Le Hegaret (plh@w3.org<mailto:plh@w3.org>)" <plh@w3.org<mailto:plh@w3.org>>, Canvas <public-canvas-api@w3.org<mailto:public-canvas-api@w3.org>>, Richard Schwerdtfeger/Austin/IBM@IBMUS
Date: 01/09/2014 11:21 AM
Subject: Re: drawSystemFocusRing and drawCustomFocusRing names are confusing.
________________________________



I'd very much support just calling it drawFocus.

- Dominic

On Thu, Jan 9, 2014 at 9:07 AM, Jatinder Mann <jmann@microsoft.com<mailto:jmann@microsoft.com>> wrote:
Regarding Bug 23980 – drawSystemFocusRing and drawCustomFocusRing are poorly named, https://www.w3.org/Bugs/Public/show_bug.cgi?id=23980, I would like to talk more about this bug in next Monday's Canvas Accessibility Sub Group meeting. I think we should consider updating the name of drawSystemFocusRing in the L1 spec to make the feature more clear to web developers. I personally don't think fixing the name should mean that we need to push this API out to the L2 spec; it’s quite reasonable to update the name in the L1 spec, especially if we will likely be going to Last Call anyway. Just because some old Win32 API is using this sort of name doesn't mean we should confuse web developers and impact the adoption of this API.



I don't like the use of "System" because it sounds like we are using the OS focus, whereas we really mean User Agent focus. E.g., On Windows, Chrome uses an orange focus which is different from the system dotted focus. I rather we just remove the word "System" for this method. The "Custom" version should keep the word "Custom" because it is a custom focus that the web developer draws.



I don't like the use of "Ring". You can use the Canvas API to draw any path, not just a ring. We can drop "Ring" and go with "Region", "Path", or nothing at all.



I don't particularly like the use of "draw" as we only draw if the area is focused. Other draw calls like "drawImage" always draw once the call is made. I can see that "set" may be confusing as it may appear that we are setting the focus, not the user. Since it may be the least confusing, I think we should leave "draw" in.



How does "drawFocus" instead of "drawSystemFocusRing" and "drawCustomFocus" instead of "drawCustomFocusRing" sound? I know naming may sound like a minor thing, but if we are spending the time to fix the defects in this API, we might as well get the name right.





Thanks,

Jatinder