W3C home > Mailing lists > Public > public-autowebplatform@w3.org > October 2014

Re: incorrect "unsigned short" in Vehicle Data doc

From: Rees, Kevron <kevron.m.rees@intel.com>
Date: Wed, 8 Oct 2014 09:22:21 -0700
Message-ID: <CAFW5wYaYU9rz3E8onLfH1tvrj8LPWn2oU9NkMOeWxbqB5eonwA@mail.gmail.com>
To: Dominique Hazael-Massieux <dom@w3.org>
Cc: "public-autowebplatform@w3.org" <public-autowebplatform@w3.org>
Thank you for the feedback.  I will audit what you have pointed out
and correct the errors.

-Kevron

On Tue, Oct 7, 2014 at 4:58 AM, Dominique Hazael-Massieux <dom@w3.org> wrote:
> Hi,
>
> While glancing through
> https://rawgit.com/w3c/automotive-bg/master/data_spec.html I noticed the
> following properties are marked as "unsigned short" while they are
> described as taking negative values:
> * Mirror.mirrorPan
> * Mirror.mirrorTilt
> * SeatAdjustment.reclineSeatBack
>
> It is also a bit unexpected that some times, percentages are used
> relative to the per-vehicle maximum values (e.g.
> SeatAdjustment.seatCushionHeight), and other times, they're used as
> absolute values matching a pre-defined maximum value (e.g.
> SeatAdjustment.reclineSeatBack)
>
> Some of the percentage values are defined as "unsigned byte" (whereas
> most are defined as "unsigned short"): Sunroof.openness, Sunroof.tilt,
> SideWindow.openness.
>
> 9.3 says that RainSensor provides information about ambient light levels
> — I assume it should be rain intensity.
>
> The mapping between the various interfaces that inherit from
> VehicleCommonDataType and the objects that can be used in the
> VehicleSignalInterface.set method is not well-defined at the moment;
> clearly, the "zone" attribute is not expected to set both in these
> objects and as the second parameter of VehicleSignalInterface.set.
>
> It's not clear to me why the "zone" attribute of the various
> VehicleCommonDataType interfaces is not always read-only; that being
> said, given that these objects will mostly only be made available as
> parameters to the "subscribe" callback, it's not clear that these
> "readonly" annotations have any actual impact on the API; the objects
> would probably better represented by dictionaries rather than
> interfaces, or at an even broader level, the subscribe method would
> probably better be represented by an event listener.
>
> Dom
>
>
>
Received on Wednesday, 8 October 2014 16:22:49 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:06:40 UTC