- From: Raymond Toy <rtoy@google.com>
- Date: Thu, 8 Mar 2018 13:21:21 -0800
- To: Paul Adenot <padenot@mozilla.com>
- Cc: "public-audio@w3.org Group" <public-audio@w3.org>, Tab Atkins <tabatkins@google.com>
- Message-ID: <CAE3TgXFeHP5fvPbM3EN4K1N2MS9wW_j7vqg2HRmssEqWShgULg@mail.gmail.com>
The bikeshed version has been committed. (See https://github.com/WebAudio/web-audio-api/pull/1514) Travis CI is basically ineffective now because there are errors with the current spec (some due to bokeshed). So you'll have to check manually to make sure an PRs work. This also means you need a copy of bikeshed locally (probably). See https://tabatkins.github.io/bikeshed/ for details on how to use bikeshed. We will want to set up travis ci to generate the html version automatically. Hopefully soon. And finally, many thanks to Tab Atkins who volunteered to do the conversion for us and did practically the entire spec by himself. I just cleaned up a few issues that would have been difficult for someone unfamiliar with the spec to know about. Any problems with this version are all due to me. On Mon, Mar 5, 2018 at 8:52 AM, Raymond Toy <rtoy@google.com> wrote: > I'm going to merge the bikeshed changes this Tue or Wed. > > If you have changes to the spec already, this merge is going to break > them. So please hold off on the changes or let me know so that the merge > can be done after your changes. > > > On Tue, Feb 27, 2018 at 9:24 AM, Paul Adenot <padenot@mozilla.com> wrote: > >> I hadn't thought about the name change, sorry. >> >> I think this is all good. Simply merging using the squash function of >> github will do. >> >> Paul. >> >> On Tue, Feb 27, 2018 at 5:43 PM, Raymond Toy <rtoy@google.com> wrote: >> >>> I'll look in to it. Since the spec source will be in the new file >>> index.bs, the history there shouldn't matter. But we probably do want >>> index.html to get squashed. Possibly would work by just doing a normal >>> merge commit? >>> >>> I'll be sure to tag the repo before doing the merge so we can still go >>> back and see what it looked like before bikeshed in case some strangeness >>> happens. >>> >>> I tried fairly hard to preserve all text, even when there were obvious >>> typos. But in fixing bikeshed errors, I did convert some stuff to be >>> actual links instead of code and vars and other markup. I think the result >>> isn't too much different from the current version. >>> >>> On Tue, Feb 27, 2018 at 2:38 AM, Paul Adenot <padenot@mozilla.com> >>> wrote: >>> >>>> Sounds good. >>>> >>>> Can do squash the conversion commits locally, and push to the repo as a >>>> single commit, so that the history remains quite clear nonetheless? >>>> >>>> Thanks, >>>> Paul. >>>> >>>> On Tue, Feb 27, 2018 at 12:17 AM, Raymond Toy <rtoy@google.com> wrote: >>>> >>>>> The conversion of the spec to bikeshed is, essentially, done with much >>>>> help from Tab Atkins. There are currently 6 errors generated by bikeshed. >>>>> Of these, one is a bad link on our part (cors-cross-origin no longer links >>>>> to anything useful). The rest are small issues with bikeshed such tat inks >>>>> to MediaStream, MediaStreamTrack, and DOMHighResTimestamp don't link to >>>>> anything in the IDL sections like other things normally would (like >>>>> HTMLMediaElement, and so on.) >>>>> >>>>> AFAICT, everything else works and the spec looks good. (Preview at >>>>> https://rawgit.com/tabatkins/web-audio-api/gh-pages/index.html) >>>>> >>>>> So, barring any last minute issues, I'd really like to import the >>>>> bikeshed version in the next week or two so that I don't have to merge >>>>> changes manually between the two versions anymore. >>>>> >>>>> Until the bikeshed errors are fixed, we won't easily be able to have >>>>> CI check for mistakes. Hopefully that will get remedied soon. >>>>> >>>>> >>>>> >>>> >>> >> >
Received on Thursday, 8 March 2018 21:21:48 UTC