Re: AccName test expectations bug + prototype bug?

Update/correction on what I state below: Even Gecko doesn't produce the
correct result. Now that the tests in question were updated so that
input's title is "buz" instead of "bar", Gecko's calculation is "foo buz
baz." This is 100% failing in implementations.

--joanie

On 9/28/18 11:14 AM, Joanmarie Diggs wrote:
> Thanks Bryan. I'm afraid, however, I'm still not convinced that the
> outer title "bar" gets used. And only Gecko is using it; all of the
> other user agents are not. So I spent some time writing out in painful
> deal what I think the algorithm says to do and opened an issue against
> AccName.
> 
> It would be super helpful if people could read over it and tell me why I
> (and all implementors sans Mozilla) are wrong as **clearly demonstrated
> in the language of the AccName spec.** If I am wrong, I promise to
> finally shut up about this one and fix WebKit and Blink. :) Otherwise, I
> say we skip these two tests and fix the issue in 1.2.
> 
> Here's the issue: https://github.com/w3c/accname/issues/31
> 
> Sorry for being dense. And thanks for all your help!
> --joanie
> 
> On 9/27/18 11:23 PM, Bryan Garaventa wrote:
>> Got it, they should now match. :) 
>>
>>
>> Bryan Garaventa
>> Accessibility Fellow
>> Level Access, Inc.
>> Bryan.Garaventa@LevelAccess.com
>> 415.624.2709 (o)
>> www.LevelAccess.com
>>
>> -----Original Message-----
>> From: Joanmarie Diggs <jdiggs@igalia.com> 
>> Sent: Thursday, September 27, 2018 10:15 AM
>> To: Bryan Garaventa <bryan.garaventa@levelaccess.com>
>> Cc: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>; nurthen@adobe.com; public-aria@w3.org
>> Subject: Re: AccName test expectations bug + prototype bug?
>>
>> Thanks Bryan.
>>
>> Ok, I changed 659 and 660 on the wiki so that the title of the input is "buz" rather than "bar". Could you please update your tool to reflect that change?
>>
>> Thanks again!
>> --joanie
>>
>> On 9/27/18 12:59 PM, Bryan Garaventa wrote:
>>> Hi,
>>> Sorry for the delay, been out sick this week.
>>>
>>> This looks correct to me.
>>>
>>> These were the test that I recommended changing the title="bar" on the input element to "buz" instead, because it's hard to know what is happening when it matches the title on the outer label.
>>>
>>> Basically, only the outer title is computed as the name, and the CSS before and after content is prepended and appended accordingly to that, which I believe matches what the spec says.
>>>
>>> The second title="bar" is being added to Description however, because only the value of embedded nodes is supposed to be processed on form fields and not any other naming mechanism. So if that was changed to title="buz" it would show this more clearly.
>>>
>>>
>>> Bryan Garaventa
>>> Accessibility Fellow
>>> Level Access, Inc.
>>> Bryan.Garaventa@LevelAccess.com
>>> 415.624.2709 (o)
>>> www.LevelAccess.com
>>>
>>> -----Original Message-----
>>> From: Joanmarie Diggs <jdiggs@igalia.com>
>>> Sent: Wednesday, September 26, 2018 9:54 AM
>>> To: Bryan Garaventa <bryan.garaventa@levelaccess.com>
>>> Cc: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>; nurthen@adobe.com; 
>>> public-aria@w3.org
>>> Subject: Re: AccName test expectations bug + prototype bug?
>>>
>>> Hey Bryan, all.
>>>
>>> Can you please check other tests, for instance 659 and 660. When I try 
>>> https://whatsock.github.io/w3c-alternative-text-computation/Autogenera
>>> ted%20AccName%201.1%20Testable%20Statements%20-%20W3C/Name%20test%20ca
>>> se%20659.html, it says the name is "foo bar baz". Is that correct?
>>>
>>> Thanks!
>>> --joanie
>>>
>>> On 9/13/18 2:10 PM, Joanmarie Diggs wrote:
>>>> I updated the tests which are impacted. Thanks!
>>>> --joanie
>>>>
>>>> On 09/13/2018 01:22 PM, Bryan Garaventa wrote:
>>>>> There is a drawback to this however, since the change now 
>>>>> invalidates test 661 at 
>>>>> https://www.w3.org/wiki/AccName_1.1_Testable_Statements
>>>>>
>>>>> Which you can run using the link below the heading of that test to see what I mean.
>>>>>
>>>>> So there are likely other places where this will occur as well. Small changes impact everything...
>>>>>
>>>>>
>>>>>
>>>>> Bryan Garaventa
>>>>> Accessibility Fellow
>>>>> Level Access, Inc.
>>>>> Bryan.Garaventa@LevelAccess.com
>>>>> 415.624.2709 (o)
>>>>> www.LevelAccess.com
>>>>>
>>>>> -----Original Message-----
>>>>> From: Bryan Garaventa <bryan.garaventa@levelaccess.com>
>>>>> Sent: Thursday, September 13, 2018 10:00 AM
>>>>> To: Joanmarie Diggs <jdiggs@igalia.com>; Carolyn MacLeod 
>>>>> <Carolyn_MacLeod@ca.ibm.com>
>>>>> Cc: nurthen@adobe.com; public-aria@w3.org
>>>>> Subject: RE: AccName test expectations bug + prototype bug?
>>>>>
>>>>> For the markup,
>>>>>
>>>>> <label for="test">foo <input id="test" type="button" name="test" 
>>>>> title="bar"> baz</label>
>>>>>
>>>>> I have the result for
>>>>>
>>>>> accName: "foo baz"
>>>>>
>>>>> accDesc: "bar"
>>>>>
>>>>> (Running AccName Computation Prototype version: 2.16)
>>>>>
>>>>> There was a bug in that processing which I fixed a few minutes ago, but title shouldn't be processed on subnodes of a tree and added to name.
>>>>>
>>>>> Bryan Garaventa
>>>>> Accessibility Fellow
>>>>> Level Access, Inc.
>>>>> Bryan.Garaventa@LevelAccess.com
>>>>> 415.624.2709 (o)
>>>>> www.LevelAccess.com
>>>>>
>>>>> -----Original Message-----
>>>>> From: Joanmarie Diggs <jdiggs@igalia.com>
>>>>> Sent: Wednesday, September 12, 2018 3:10 PM
>>>>> To: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
>>>>> Cc: Bryan Garaventa <bryan.garaventa@levelaccess.com>;
>>>>> nurthen@adobe.com; public-aria@w3.org
>>>>> Subject: Re: AccName test expectations bug + prototype bug?
>>>>>
>>>>> On 09/12/2018 05:39 PM, Carolyn MacLeod wrote:
>>>>>> The 2 spaces is for your simpler variant:
>>>>>> <label for="test">foo <input id="test" type="button" name="test"
>>>>>> title="bar"> baz</label>
>>>>>
>>>>> Right. Though whether or not it should be is, I think, up to the HTML-AAM. What implementors are actually doing is another question, but, again, I believe what they do is simplify/collapse whitespace.
>>>>>
>>>>>> As for the CSS ::before and ::after content in test case 661 
>>>>>> <https://www.w3.org/wiki/AccName_1.1_Testable_Statements#Name_test_
>>>>>> c as e_661>, I guess the accessible name would be "foobaz" (no 
>>>>>> space?)
>>>>>
>>>>> Another question for the group. My guess is that we (the group) assume it should be "foo baz", but what's in AccName step 2.F.ii suggests to me that the space wouldn't be there. Thursday's going to be a fun meeting.
>>>>> I can tell. :)
>>>>>
>>>>>> and the
>>>>>> accessible description would be " bar " (with space before and 
>>>>>> after?), except that I'm not really sure about those.
>>>>>
>>>>> Me neither. Another topic for Thursday I guess.
>>>>>
>>>>> --joanie
>>>>>
>>>>
>>>
>>
> 
> 
>

Received on Monday, 1 October 2018 13:51:56 UTC