W3C home > Mailing lists > Public > public-aria-editors@w3.org > January 2020

Re: Github PR review assignment

From: Michael Cooper <cooper@w3.org>
Date: Fri, 3 Jan 2020 08:47:49 -0500
To: James Nurthen <nurthen@adobe.com>, ARIA Editors <public-aria-editors@w3.org>
Message-ID: <71b17f12-a23e-dcb1-c2c6-933bd5939231@w3.org>
A few thoughts come to mind:

  * In principle, automatic review assignment sounds good.
  * I think this will work best with a certain kind of review - the
    substantive proposals the group discusses in meetings. Editorial
    issues and stuff seem to benefit less, so we'll have to socialize
    using this only in the right situations.
  * If we do this, I'd like to try the "round robin" approach first,
    where everyone is assigned the same number of reviews over time. If
    we find reviews from certain people stacking up, we could remove
    them from the list of reviewer candidates or switch to load
    balancing reviews. But this means Carolyn will get assigned most of
    the reviews, so I think we should socialize effective use of
    round-robin instead, i.e., make sure people do their reviews.
  * I doubt that all members of the "aria-contributors" team are
    suitable reviewers. I can think of two ways to handle this:
      o Manually mark people as "never assign".
      o Create a separate team for review assignments, most likely a
        nested team of aria-contributors to reduce the risk of adding
        people in one team but not the other.
        https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/about-teams#nested-teams

Michael

On 20/12/2019 12:41 p.m., James Nurthen wrote:
>
> Any thoughts on using 
> https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/managing-code-review-assignment-for-your-team#configuring-code-review-assignment 
> to automate PR review assignments?
>
> We could get a list of group members who would like to join a review 
> group and then auto-assign 2 members to review every PR that comes in.
>
> Adobe Logo
>
> 	
>
> *James Nurthen*
>
> 	
>
> 415.832.2734 (tel)
>
> 	
>
> 601 Townsend Street
>
> Accessibility Engineer
>
> 	
>
> 415.987.1918 (cell)
>
> 	
>
> San Francisco, CA, 94103, USA
>
> Adobe. Make It an Experience.
>
> 	
>
> nurthen@adobe.com
>
> 	
>
> www.adobe.com
>
> 	
>
Received on Friday, 3 January 2020 13:47:52 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 18:59:25 UTC