- From: Ivan Herman via GitHub <sysbot+gh@w3.org>
- Date: Sat, 28 Jan 2017 10:40:08 +0000
- To: public-annotation@w3.org
>I didn't see the ipr check issue initially, so I guess merging should wait for Ivan since I don't know what he does to fix that? (It is a tool that checks the potential issues on IPR with external committers. I have no idea why it complaints about Benjamin, but, at this point, I am lazy to chase down this with the system team. I always mark the changes non-substantial, which essentially means there are no IPR issues, which is true for the note anyway.) >As for the substance of the examples, interesting but now that I look more closely, are we stretching the scope of the Note a little too far? As it stands are these annotations or just uses of selectors to identify the sources of quotes - i.e., just instances of the ResourceSelection class as described in the Selector Note? If so, and given that the other examples are annotations, probably should be more explicit about this distinction in introducing these examples. But if others are also, I'm okay if we want to include examples of ResourceSelection class. I think adding this section is a good idea. One of the issue, that we actually ran into yesterday without saying it, is that the identification of an element within an HTML source (using, e.g., the `@id` attribute) is _not_ the same as referring to the content of that element. (RDF affectionados are sensitive to these details.) Using the selectors is a clean way of doing that. Maybe a half-sentence emphasizing this issue would help. >It took me a bit to imagine what the json-ld for these examples would look like. Could we provide json-ld equivalents? Ivan's converter tool does a nice job with these, I think. If we were to use JSON-LD, then making use of the fragment ID-s may become unnecessary. After all, if one uses JSON-LD, then one can simply use the selectors as defined originally, without using the fragment ID! It is when using RDFa that it becomes a real advantage: instead of encoding the whole selector into HTML+RDFa (which is tedious), one could simply use a simple IRI with the fragment. That is a real win in that world... >And lastly, these are using Text Position Selector without State (which is recommended). Okay, but perhaps we should mention somewhere that a refinedBy could be added to align with the recommendation in the data model - albeit making everything more complicated (so let's not show). Presumably the document targeted is relatively static with no real dynamic content. Might need to say this too. I think this may go a little bit too far into the details. Just referring to the selector note saying that much more can be achieved by using all the possibilities (and referring to the note) might be enough. -- GitHub Notification of comment by iherman Please view or discuss this issue at https://github.com/w3c/web-annotation/pull/400#issuecomment-275840867 using your GitHub account
Received on Saturday, 28 January 2017 10:40:15 UTC