W3C home > Mailing lists > Public > public-webapps-testsuite@w3.org > February 2013

RE: RfR: Progress Events Test Cases; deadline January 28

From: Jungkee Song <jungkee.song@samsung.com>
Date: Mon, 25 Feb 2013 20:34:49 +0900
To: 'Ms2ger' <ms2ger@gmail.com>
Cc: 'Arthur Barstow' <art.barstow@nokia.com>, public-webapps-testsuite@w3.org, cpgs@samsung.com
Message-id: <05bf01ce134c$1ec82b00$5c588100$@samsung.com>
> -----Original Message-----
> From: Ms2ger [mailto:ms2ger@gmail.com]
> Sent: Thursday, February 21, 2013 10:04 PM
> >
> >> -----Original Message-----
> >> From: Arthur Barstow [mailto:art.barstow@nokia.com]
> >> Sent: Thursday, February 21, 2013 8:59 PM
> >>
> >> On 2/21/13 1:13 AM, ext Jungkee Song wrote:
> >>>> -----Original Message-----
> >>>> From: Arthur Barstow [mailto:art.barstow@nokia.com]
> >>>> Sent: Thursday, February 21, 2013 3:40 AM
> >>>>
> >>
> >> Please copy interface.html to the approved directory <http://w3c-
> >> test.org/webapps/ProgressEvents/tests/approved/>.

interface.html has been copied to approved directory.


> >>
> >> If no one objects to removing #1 and #6 from constructor.html before
> >> Feb
> >> 24 then please put a version of that file in the approved and only
> >> include the other tests.
> >>
> >
> > Checking again, IMO, only the following three assertions should be
> > retained in #1:
> >    assert_equals(ev.lengthComputable, false)
> >    assert_equals(ev.loaded, 0)
> >    assert_equals(ev.total, 0)
> > and #6 should be moved to DOM.
> >
> > Would you review it again?
> 
> I think it would make more sense to keep the assertions; Progress Events
> has a normative reference to DOM for the definition of Event. However, if
> there's a particular issue with one of them (such as isTrusted,
> apparently), I don't mind if you remove just that assertion.
> 
> As for #6, I think it's relevant to this specification, but I don't feel
> strongly.
> 

As you mentioned, I'll remove isTrusted assertion from #1 and #6 with all its assertions. I believe DOM would be the right place for them as well.


> In either case, please add the removed assertions to the DOM test suite.

I plan to add the removed assertions (the following code) as /DOMCore/tests/submissions/Ms2ger/constructor.html 
Would it be fine?

<script>
test(function() {
  var ev = new ProgressEvent("test")
  assert_equals(ev.type, "test")
  assert_equals(ev.target, null)
  assert_equals(ev.currentTarget, null)
  assert_equals(ev.eventPhase, Event.NONE)
  assert_equals(ev.bubbles, false)
  assert_equals(ev.cancelable, false)
  assert_equals(ev.defaultPrevented, false)
  assert_equals(ev.isTrusted, false)
  assert_true(ev.timeStamp > 0)
  assert_true("initEvent" in ev)
}, "Default event values.")
test(function() {
  assert_throws("NotSupportedError", function() {
    document.createEvent("ProgressEvent")
  })
}, "document.createEvent() should not work with ProgressEvent.")
</script>


> 
> Ms2ger
Received on Monday, 25 February 2013 11:35:23 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 22 April 2014 14:15:59 UTC