Re: [whatwg/fetch] Split 'document' destination into 'frame' and 'iframe'. (#948)

mikewest commented on this pull request.



> @@ -1567,13 +1573,13 @@ whose <a for=request>destination</a> is "<code>audio</code>", "<code>audioworkle
 "<code>object</code>" or "<code>embed</code>".
 
 <p>A <dfn export>non-subresource request</dfn> is a <a for=/>request</a>
-whose <a for=request>destination</a> is "<code>document</code>",
-"<code>report</code>", "<code>serviceworker</code>", "<code>sharedworker</code>",
-or "<code>worker</code>".
+whose <a for=request>destination</a> is "<code>document</code>", "<code>frame</code>",
+"<code>iframe</code>", "<code>report</code>", "<code>serviceworker</code>",
+"<code>sharedworker</code>", or "<code>worker</code>".

Ok. Is that something you want me to do in _this_ patch, which introduces `iframe` and `frame`? Or would you be ok with me splitting it out into a separate patch (which I think I'd like to do, because some things about changing `<embed>`'s mode to `navigate` aren't clear to me, and will likely require changes in both Fetch and HTML).

If you're alright with deferring it to a future patch, is there anything else we need to change about this one?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/948#discussion_r341944036

Received on Monday, 4 November 2019 08:54:05 UTC