Re: [whatwg/fetch] Split 'document' destination into 'frame' and 'iframe'. (#948)

mikewest commented on this pull request.



> @@ -1567,13 +1573,13 @@ whose <a for=request>destination</a> is "<code>audio</code>", "<code>audioworkle
 "<code>object</code>" or "<code>embed</code>".
 
 <p>A <dfn export>non-subresource request</dfn> is a <a for=/>request</a>
-whose <a for=request>destination</a> is "<code>document</code>",
-"<code>report</code>", "<code>serviceworker</code>", "<code>sharedworker</code>",
-or "<code>worker</code>".
+whose <a for=request>destination</a> is "<code>document</code>", "<code>frame</code>",
+"<code>iframe</code>", "<code>report</code>", "<code>serviceworker</code>",
+"<code>sharedworker</code>", or "<code>worker</code>".

> I'm a little worried it's gonna linger and never get fixed, despite being somewhat important from an interoperability perspective.
>
> And note that before it'd go from no-cors/embed to navigate/document and that is being changed too.

I agree that we should fix it in the spec and lock it in with tests. I'm not sure _this_ patch is the right place to do it, given how simple it is today, and how not-simple I think the `<embed>` change is going to be more generally. :)

If you'd prefer one big patch that addresses `<embed>`/`<object>`/`<frame>`/`<iframe>` all together, I'll do that! But I think I'd prefer to just land this and the associated HTML PR, and worry about `<embed>` and `<object>` in a subsequent set of PRs.

> And given that it also changes for iframe et al, there needs to be an associated HTML PR already for this change.

https://github.com/whatwg/html/pull/4976 is that change.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/948#discussion_r341984053