W3C home > Mailing lists > Public > public-device-apis@w3.org > April 2015

Re: DAP-ACTION-730: Ask zhiqiang to update the battery test suite to match latest battery spec (coordinating with marcos)

From: Kostiainen, Anssi <anssi.kostiainen@intel.com>
Date: Fri, 17 Apr 2015 09:04:31 +0000
To: "Zhang, Zhiqiang" <zhiqiang.zhang@intel.com>
CC: Device APIs Working Group <public-device-apis@w3.org>
Message-ID: <36EA0003-F1F5-446C-B582-70964AA106FE@intel.com>
Hi Zhiqiang,

> On 26 Feb 2015, at 12:02, Kostiainen, Anssi <anssi.kostiainen@intel.com> wrote:

[...]

>>>> * assess the impact on the spec progress: a precondition to exit CR would be
>>>> to get two implementations, for example, if the Chrome bugs
>>>> (http://crbug.com/43394, others?) are fixed, and Mozilla updates its
>>>> implementation (https://bugzil.la/1047119)
> 
> The remaining implementation issues blocking CR exit are
> 
> * Chrome's lack of WebIDL compliance (http://crbug.com/43394) that causes the battery-interface-idlharness.html and battery-interface.html tests to fail.

The fix (http://crbug.com/43394) has landed in Chrome M43, so I re-ran the tests that had failures [1,2] on Chrome Canary 44.0.2371.0. Results and some suggestions for test fixes:

---+ battery-interface.html [1]

I think the following remaining 16 failures:

* did not treat noncallable as null expected null

... can be fixed by removing the now obsolete test cases that test [TreatNonCallableAsNull] extended attribute behaviour on the on* EventHandlers. The latest spec has dropped that extended attribute, so related tests should be dropped too.

[ [TreatNonCallableAsNull] has been renamed to [TreatNonObjectAsNull] in the WebIDL spec, and its use is discouraged. ]

---+ battery-interface-idlharness.html [2]

The following failures remain:

* class string of BatteryManager.prototype expected "[object BatteryManagerPrototype]" but got "[object Object]"

* navigator.getBattery()'s prototype is not BatteryManager.prototype expected object "[object Object]" but got object "[object Promise]"

* class string of navigator.getBattery() expected "[object BatteryManager]" but got "[object Promise]"

* property "XXXX" not found in prototype chain [x 14]

Zhiqiang - could you look into fixing the remaining failures in battery-interface.html and battery-interface-idlharness.html? The former should be an easy fix.

> * Mozilla's implementation update to match the latest spec (https://bugzil.la/1047119).
> 
>>> Good plan. Let's move forward together.
>> 
>> Btw. the Chrome Android bug of missing an implementation of chargingTime and dischargingTime attributes has been fixed couple of days ago, see:
>> 
>> https://crbug.com/401553
>> 
>> Zhiqiang - you may want to rerun the relevant tests on a fresh Android build.
> 
> Zhiqiang - please let us know the results from Android when you're able to test with a new build.

I think https://crbug.com/401553 should now be in Chrome M42 Android.

Zhiqiang - please let us know whether this fixes the following:

---+ battery-plugging-in-manual.html [3]

* The value of the dischargingTime attribute must be set to Infinity. expected Infinity but got 10380

... that was the only remaining failure in battery-plugging-in-manual.html on Android.

Thanks,

-Anssi

[1] http://w3c-test.org/battery-status/battery-interface.html
[2] http://w3c-test.org/battery-status/battery-interface-idlharness.html
[3] http://w3c-test.org/battery-status/battery-plugging-in-manual.html
Received on Friday, 17 April 2015 09:05:09 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 14:54:05 UTC