W3C home > Mailing lists > Public > public-device-apis@w3.org > April 2015

RE: DAP-ACTION-730: Ask zhiqiang to update the battery test suite to match latest battery spec (coordinating with marcos)

From: Zhang, Zhiqiang <zhiqiang.zhang@intel.com>
Date: Wed, 29 Apr 2015 01:37:47 +0000
To: "Kostiainen, Anssi" <anssi.kostiainen@intel.com>
CC: Device APIs Working Group <public-device-apis@w3.org>
Message-ID: <0EA8FB2070816C499E0A50AC1B0B5C1601823FC0@SHSMSX101.ccr.corp.intel.com>
Hi Anssi,

> From: Kostiainen, Anssi
> Sent: Friday, April 17, 2015 17:05
 
> The fix (http://crbug.com/43394) has landed in Chrome M43, so I re-ran the
> tests that had failures [1,2] on Chrome Canary 44.0.2371.0. Results and some
> suggestions for test fixes:
> 
> ---+ battery-interface.html [1]
> 
> I think the following remaining 16 failures:
> 
> * did not treat noncallable as null expected null
> 
> ... can be fixed by removing the now obsolete test cases that test
> [TreatNonCallableAsNull] extended attribute behaviour on the on*
> EventHandlers. The latest spec has dropped that extended attribute, so
> related tests should be dropped too.

Thanks for pointing out this. Tests related were removed at
https://github.com/w3c/web-platform-tests/pull/1775

> [ [TreatNonCallableAsNull] has been renamed to [TreatNonObjectAsNull] in
> the WebIDL spec, and its use is discouraged. ]
> 
> ---+ battery-interface-idlharness.html [2]
> 
> The following failures remain:
> 
> * class string of BatteryManager.prototype expected "[object
> BatteryManagerPrototype]" but got "[object Object]"
> 
> * navigator.getBattery()'s prototype is not BatteryManager.prototype
> expected object "[object Object]" but got object "[object Promise]"
> 
> * class string of navigator.getBattery() expected "[object BatteryManager]"
> but got "[object Promise]"
> 
> * property "XXXX" not found in prototype chain [x 14]
> 
> Zhiqiang - could you look into fixing the remaining failures in battery-
> interface.html and battery-interface-idlharness.html? The former should be
> an easy fix.

OK, will do these soon.

Thanks,
Zhiqiang
Received on Wednesday, 29 April 2015 01:38:20 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 14:54:05 UTC