W3C home > Mailing lists > Public > public-css-testsuite@w3.org > October 2014

Re: CSS Grid Layout tests suite

From: Manuel Rego Casasnovas <rego@igalia.com>
Date: Fri, 31 Oct 2014 11:28:25 +0100
Message-ID: <54536449.9050904@igalia.com>
To: public-css-testsuite@w3.org
Hi Gérard,

On 30/10/14 21:27, Gérard Talbot wrote:
> Le 2014-10-30 11:55, Manuel Rego Casasnovas a écrit :
> I'm not familiar with GitHub as of now. I do not think this prevents me
> from reviewing your tests. I am familiar with Shepherd application
> ( http://test.csswg.org/shepherd/ ) and Mercurial .

I was following what is explained at:
http://testthewebforward.org/docs/submission-process.html

I don't mind to use a different workflow, whatever works best for you.
However I didn't found documentation about how I should submit patches
for review in Shepherd.
Checking other examples in Shepherd and if I understood it properly. It
seems that I should request commit access and push the tests directly
there. Then you'd review them inside Shepherd and new changes will be
done on top of the original tests until they're approved.

Take into account that this contradicts the README file in the tests
repository:
"Please note that although we will grant write access directly to the
Mercurial repo, it is strongly advised to use GitHub for test
submissions to enable reviewers to use its built-in review tools. Direct
submissions to Mercurial should be limited to administrative or
housekeeping tasks, very minor changes that don't require a review, or
from advanced users of the system."

Anyway, I'm open to follow whatever you suggest. :-)

>> Probably, we could use milestones and issues too (like other specs are
>> doing), in order to follow the progress.
>> I don't have permissions to create labels and milestones at this point,
>> so I'd be grateful if someone can create a milestone "css-grid-1_dev"
>> and a label "spec:grid".
> 
> Unfortunately, I can not help you with that.

If finally we we don't use GitHub, probably we could forget about this
(it was just an idea).
Otherwise, if we end up using GitHub I hope I could find someone to help
us with this.

> A bit more explanations on how to reduce test linkages. Ideally, you
> want to reuse as much as possible already-created-and-available
> reference test files. The references test files that are frequently used
> and reused are prefixed with "ref-".
> 
> ref-filled-green-100px-square is referenced by ~= 200 tests
> ref-if-there-is-no-red is referenced by ~= 300 tests

I didn't know about the "ref-" prefixed files, interesting stuff. I
agree with you that it's a good idea try to reuse them when possible.

Thanks for sharing the other notes and comments too.

Cheers,
  Rego
Received on Friday, 31 October 2014 10:28:59 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 21:13:27 UTC