W3C home > Mailing lists > Public > public-css-testsuite@w3.org > October 2014

Re: CSS Grid Layout tests suite

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Fri, 31 Oct 2014 17:52:33 -0400
To: Manuel Rego Casasnovas <rego@igalia.com>
Cc: Public CSS Test suite mailing list <public-css-testsuite@w3.org>
Message-ID: <64e7e316abcc8a624a2daa1a7ae2559a@gtalbot.org>
Le 2014-10-31 06:28, Manuel Rego Casasnovas a écrit :
> Hi Gérard,
> 
> On 30/10/14 21:27, Gérard Talbot wrote:
>> Le 2014-10-30 11:55, Manuel Rego Casasnovas a écrit :
>> I'm not familiar with GitHub as of now. I do not think this prevents 
>> me
>> from reviewing your tests. I am familiar with Shepherd application
>> ( http://test.csswg.org/shepherd/ ) and Mercurial .
> 
> I was following what is explained at:
> http://testthewebforward.org/docs/submission-process.html
> 

Rego,

What you are doing is correct. I am the one who should be learning how 
to use, interact and work with GitHub. I am trying to do that today..

> I don't mind to use a different workflow, whatever works best for you.

One sure thing you can do is email me and +CC the mailing list. For 
now... until I am able to manage with GitHub

> However I didn't found documentation about how I should submit patches
> for review in Shepherd.

I use Mercurial to submit modifications to tests. Again, GitHub is the 
new, preferred and recommended way of submitting patches, corrections, 
modifications now.

> Checking other examples in Shepherd and if I understood it properly. It
> seems that I should request commit access and push the tests directly
> there. Then you'd review them inside Shepherd and new changes will be
> done on top of the original tests until they're approved.
> 
> Take into account that this contradicts the README file in the tests
> repository:
> "Please note that although we will grant write access directly to the
> Mercurial repo, it is strongly advised to use GitHub for test
> submissions to enable reviewers to use its built-in review tools. 
> Direct
> submissions to Mercurial should be limited to administrative or
> housekeeping tasks, very minor changes that don't require a review, or
> from advanced users of the system."
> 
> Anyway, I'm open to follow whatever you suggest. :-)

Email me and +CC the mailing list. For now.
Make sure your email subject line has the base-filename of the test for 
which you want a review. No more than 3 tests per email (more than 3 
would make the subject line too long). Having the base filename of test 
in the subject line is to make archived emails searchable, is to ensure 
searchability of archived emails later.

Eg. (with fictional tests)
[Grid-Layout] grid-layout-repeat-notation-003, grid-layout-grid-span-005 
and grid-layout-auto-tracks-001: review request

and start each section of the body of the email with the URL of each 
test

eg. (fictional tests)
1-
http://test.csswg.org/source/css-grid-1/grid-layout-repeat-notation-003.html
(...)

2-
http://test.csswg.org/source/css-grid-1/grid-layout-grid-span-005.html
(...)
3-
http://test.csswg.org/source/css-grid-1/grid-layout-auto-tracks-001.html
(...)

Eg
http://lists.w3.org/Archives/Public/public-css-testsuite/2013Jun/0040.html
but here, the link

[src]
http://test.csswg.org/source/contributors/opera/submitted/multicol/multicol-margin-001.xht

would be now (after the CSS test repository refactoring)

[source]
http://test.csswg.org/source/css-multicol-1/multicol-margin-001.xht



> 
>>> Probably, we could use milestones and issues too (like other specs 
>>> are
>>> doing), in order to follow the progress.
>>> I don't have permissions to create labels and milestones at this 
>>> point,
>>> so I'd be grateful if someone can create a milestone "css-grid-1_dev"
>>> and a label "spec:grid".
>> 
>> Unfortunately, I can not help you with that.
> 
> If finally we we don't use GitHub, probably we could forget about this
> (it was just an idea).

I am trying to learn to use GitHub, how to use it for submitting tests 
myself and to review tests. It may take me quite some time...

> Otherwise, if we end up using GitHub I hope I could find someone to 
> help
> us with this.
> 
>> A bit more explanations on how to reduce test linkages. Ideally, you
>> want to reuse as much as possible already-created-and-available
>> reference test files. The references test files that are frequently 
>> used
>> and reused are prefixed with "ref-".
>> 
>> ref-filled-green-100px-square is referenced by ~= 200 tests
>> ref-if-there-is-no-red is referenced by ~= 300 tests
> 
> I didn't know about the "ref-" prefixed files, interesting stuff.

This "ref-" prefixing of very frequently reused reference files was 
documented in the previous documentation.

{
Common References

There are several common references, such as those used for parsing and 
selectors tests. Their names begin with ref- so they can be easily found 
in the reftest directory. Email public-css-testsuite@w3.org if you would 
like to add to the common references collection.
}
https://wiki.csswg.org/test/reftest#the-reftest-reference-file


I do not see this "ref-" prefixing of very frequently reused reference 
files in current documentation.


> agree with you that it's a good idea try to reuse them when possible.
> 
> Thanks for sharing the other notes and comments too.
> 
> Cheers,
>   Rego

Gérard
-- 
Test Format Guidelines
http://testthewebforward.org/docs/test-format-guidelines.html

Test Style Guidelines
http://testthewebforward.org/docs/test-style-guidelines.html

Test Templates
http://testthewebforward.org/docs/test-templates.html

CSS Naming Guidelines
http://testthewebforward.org/docs/css-naming.html

Test Review Checklist
http://testthewebforward.org/docs/review-checklist.html

CSS Metadata
http://testthewebforward.org/docs/css-metadata.html
Received on Friday, 31 October 2014 21:53:13 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 21:13:27 UTC