W3C home > Mailing lists > Public > public-css-testsuite@w3.org > March 2013

Re: [css3-writing-modes] vertical-alignment-001

From: Shiozawa, Hajime <hajime.shiozawa@gmail.com>
Date: Fri, 22 Mar 2013 19:13:17 +0900
Message-ID: <CAHSwuKN1ZMogVo7FLa7wP5Lpq4gD1MOtoPpMwLKxtr+g9oFfUg@mail.gmail.com>
To: "Gérard Talbot" <css21testsuite@gtalbot.org>
Cc: Public CSS test suite mailing list <public-css-testsuite@w3.org>
Hello Gérard,

I've re-submitted tests and there is a lot of modification.

1.
I replaced 'black strip' with 'black stripe'. I made mistaken.

2.
I added the additional rectangle as reference in all **horizontal** layout test.
Also I made ref-test for all horizontal layout test too.
I'm considering about creating reference rectangle and ref-test for
vertical layout test, but now I don't have good idea for it...

3.
I replaced 'inline block' with 'inline-block'.

4.
I changed titles of inline-block-alignment-** tests.

before: CSS Writing Modes Test: inline block alignment - inline block
containing two blocks (...)
after: CSS Writing Modes Test: inline-block alignment - inline-block
with content (...)

before: CSS Writing Modes Test: inline block alignment - empty inline
block (...)
after: CSS Writing Modes Test: inline-block alignment - inline-block
without content (...)

5.
I removed margin-top: 10px from div style block and added it into div
> p style block.

before:
div {
  margin-top: 10px;
}
div > p, div.control {
  font-size: 2em;
  background-color: orange;
}

after:
div > p, p.control {
  margin-top: 1em;
  font-size: 2em;
  background-color: orange;
}

6.
I replaced '.' with 'and' in test condition statement of all tests.

7.
I replaced 'yellow box' with 'yellow square' in tests.
I renamed image file from 'horiz-box' and 'vert-box' to 'yellow-square'.

8.
I replaced '_' with '-' in the name of image file.

9.
I created following image files which show reference line as red line.
  yellow-square-horiz-redline-bottom-59x59.png
  yellow-square-vert-redline-center-59x59.png
  yellow-square-vert-redline-left-59x59.png
  yellow-square-vert-redline-right-59x59.png

10.
I removed unneeded <span> tag in vertical-alignment-**.xht.

11.
> > http://test.csswg.org/source/contributors/hshiozawa/submitted/css3-writing-modes/text-baseline-003-lr.xht
> "Test passes if the *left* edge of black stripe is touching a thin blue line (...)"
> Shouldn't it be instead
> Test passes if the *right* edge of black stripe is touching a thin blue line
> ?

I think that "left edge" is correct because 'over' ('top') is 'right'
in terms of the line position when the dominant baseline is central.
So the black stripe is aligned right side and blue line touches the
left side of black stripe.

In writing-modes spec section 4.4^[1], there are direction mapping table.
According to this mapping table, when writing-modes is 'vertical-lr'
and text-orientation is 'mixed/upright/sideways-right', 'over' ('top')
position is 'right' position.
In other words, when dominant baseline is central, the physical line
direction is always same regardless of vertical-lr or vertical-rl;
always 'over' ('top') is 'right' and 'under' ('bottom') is left.

When I created some tests, I misunderstood this specification. I'm
sorry for the confusion.

[1]: http://dev.w3.org/csswg/css3-writing-modes/#logical-to-physical


> Please note that I will not be able to review your tests for a few days
> for work reasons. I must also catch up on a long list of things, matters
> that I have delayed over time, during weeks. So it may take me a week or
> 10 days before I reply to you.
OK, I understand.


Regards,
Hajime.


-- 
# 塩澤 元 (Shiozawa, Hajime)
# mail: hajime.shiozawa@gmail.com
Received on Friday, 22 March 2013 10:13:44 GMT

This archive was generated by hypermail 2.3.1 : Friday, 22 March 2013 10:13:47 GMT