W3C home > Mailing lists > Public > public-css-testsuite@w3.org > March 2013

[css3-writing-modes] vertical-alignment-001

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Wed, 13 Mar 2013 20:18:52 -0400
Message-ID: <4cae0fe79e41ef8a3a80255d1e4b01f9.squirrel@ed-sh-cp3.entirelydigital.com>
To: "塩澤 元 (Shiozawa, Hajime)" <hajime.shiozawa@gmail.com>
Cc: "Public CSS test suite mailing list" <public-css-testsuite@w3.org>
Hello Hajime

http://test.csswg.org/source/contributors/hshiozawa/submitted/css3-writing-modes/vertical-alignment-001.xht

I would replace the "." with an "and" so that it would be perfectly
clear to testers that all 3 conditions must be met, all 3 conditions
must succeed for the test to be passed.

"yellow box" ==> "yellow square": box is never a good shape descriptor
in the pass/fail conditions sentence.

horiz-box_59x59.png: has 3 blue lines. To simplify the task of testers,
I suggest to just have 1 blue line in horiz-box_59x59.png . The way the
test is designed will make the blue blue-horiz-line-220x1.png line go
under the horiz-box_59x59.png but it still must be vertically aligned
the same as with "LLLL"; the horiz-box_59x59.png must still be "sitting"
on the baseline.

I believe filename of support files should avoid underscore ("_")
character and use hyphen ("-") character instead: I've asked Peter Linss
to confirm this.

I would rename horiz-box_59x59.png to yellow-square-59x59.png

The <span> element in the 6 sub-tests is not needed; it's not a mistake
but, since it is not styled, I do not think it should be in the 6
sub-tests.

The yellow square <img> and "L" glyph in the 6 sub-tests are useful as
the bottom of both elements (inline replaced element and inline
non-replaced element) should all be lining up vertically with the blue
line, should both be touching the blue line. In reality, the blue line
is overlapping the bottom of "L" glyph and yellow square.

So, I've "puttered" around your test and I believe

vertical-alignment-001-review2.xht

is more correct than

vertical-alignment-001-review.xht

Eg.

http://www.gtalbot.org/BrowserBugsSection/review/vertical-alignment-001-review.xht

http://www.gtalbot.org/BrowserBugsSection/review/vertical-alignment-001-review2.xht

with its reftest:
http://www.gtalbot.org//BrowserBugsSection/review/reference/vertical-alignment-001-review2-ref.xht

Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Thursday, 14 March 2013 00:19:24 GMT

This archive was generated by hypermail 2.3.1 : Thursday, 14 March 2013 00:19:27 GMT