Re: checklink: suppress expected errors to avoid false positive warnings

On Monday 20 October 2008, Michael Ernst wrote:
>
> > I don't like the wildly varying separator characters in option values
> > (->, :, #).  Better would be consistent, and we already have the space
> > char used in --masquerade so I suggest using space for the new options as
> > well.
>
> I think the current separator characters consistent and readable.  For
> instance, if we want to suppress warnings about links to
>
>   http://foo.com/bar.html#baz
>
> then it appears that way in the option rather than as the less readable
>
>   http://foo.com/bar.html baz
>
> Likewise, -> is exactly the character sequence that checklink currently
> uses to print out the directory redirect warning message, so writing it
> that way in the option makes sense.
>
> These intuitive, easy-to-recognize separator characters are consistent with
> the checklink output.  I think that replacing them by spaces would make the
> options more difficult and error-prone to read and write.

Well, I guess we'll just have to disagree on this one, in my opinion using the 
space consistently everywhere for similar option syntaxes is clearly the 
better choice.

Otherwise the latest incarnation of your patch you sent me in private mail 
(I'm not sure if it was ever sent to the list) looks fine.  Caveat: I haven't 
actually tested it, just skimmed the code, so I'm taking your word for that 
it works as intended.  Feel free to commit it, but only after changing the 
different option separators all to spaces (in code and docs); or 
alternatively if the consensus of others on this list and the QA dev tools 
team is clearly in favour of using the ->, # and :, commit as is.  But not 
before people have clearly indicated being in favour of using them instead of 
spaces as the separator.

Received on Monday, 10 November 2008 21:38:31 UTC