W3C home > Mailing lists > Public > www-validator-cvs@w3.org > August 2007

validator/httpd/cgi-bin check,1.557,1.558

From: Ville Skytta via cvs-syncmail <cvsmail@w3.org>
Date: Thu, 23 Aug 2007 15:31:57 +0000
To: www-validator-cvs@w3.org
Message-Id: <E1IOEf7-0006x6-Hr@lionel-hutz.w3.org>

Update of /sources/public/validator/httpd/cgi-bin
In directory hutz:/tmp/cvs-serv26691

Modified Files:
	check 
Log Message:
Comment out the "OpenSP reports errors beyond EOL" workaround altogether for now.

Index: check
===================================================================
RCS file: /sources/public/validator/httpd/cgi-bin/check,v
retrieving revision 1.557
retrieving revision 1.558
diff -u -d -r1.557 -r1.558
--- check	22 Aug 2007 06:25:06 -0000	1.557
+++ check	23 Aug 2007 15:31:54 -0000	1.558
@@ -2545,12 +2545,15 @@
   # Workaround for onsgmls as of 1.5 sometimes allegedly reporting errors
   # beyond EOL.  If you see this warning in your web server logs, please
   # let the validator developers know, see http://validator.w3.org/feedback.html
-  if ((my $l = length($File->{Content}->[$err->{line}-1])) < $err->{char}) {
-    #warn("Warning: reported error column larger than line length " .
-    #     "($err->{char} > $l) in $File->{URI} line $err->{line}, " .
-    #     "OpenSP bug? Resetting to line length.");
-    $err->{char} = $l;
-  }
+  # As long as $err may be from somewhere else than the document (such as
+  # from a DTD) and we have no way of identifying these cases, this
+  # produces bogus results and error log spewage, so commented out for now.
+#  if ((my $l = length($File->{Content}->[$err->{line}-1])) < $err->{char}) {
+#    warn("Warning: reported error column larger than line length " .
+#         "($err->{char} > $l) in $File->{URI} line $err->{line}, " .
+#         "OpenSP bug? Resetting to line length.");
+#    $err->{char} = $l;
+#  }
 
   # No or unknown FPI and a relative SI.
   if ($err->{msg} =~ m(cannot (open|find))) {
Received on Thursday, 23 August 2007 15:32:06 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 23:02:24 UTC