- From: Bjoern Hoehrmann via cvs-syncmail <cvsmail@w3.org>
- Date: Sat, 10 Sep 2005 07:06:30 +0000
- To: www-validator-cvs@w3.org
Update of /sources/public/validator/httpd/cgi-bin
In directory hutz:/tmp/cvs-serv13729
Modified Files:
check
Log Message:
some cleanup; qa-dev hopefully runs the latest spo/osp...
Index: check
===================================================================
RCS file: /sources/public/validator/httpd/cgi-bin/check,v
retrieving revision 1.445
retrieving revision 1.446
diff -u -d -r1.445 -r1.446
--- check 28 Aug 2005 20:53:09 -0000 1.445
+++ check 10 Sep 2005 07:06:27 -0000 1.446
@@ -581,22 +581,16 @@
#
# Parser configuration
- #
- # This is broken on Win32 with restrict_file_reading since it
- # would need to allow access to the temp file directory which
- # it does not. Not sure how to address that yet.
$opensp->search_dirs($CFG->{Paths}->{SGML}->{Library});
$opensp->catalogs($catalog);
$opensp->show_error_numbers(1);
#
- # Note: if you feel the urge to remove -R from here, please understand that
- # doing so opens a potential security hole. Don't do that; instead just
- # make sure you're running OpenSP 1.5 or later.
- $opensp->restrict_file_reading(1);
-
- # workaround for odd O::S::P behavior...
- $opensp->pass_file_descriptor(1) unless $^O eq 'MSWin32';
+ # Restricted file reading is disabled on Win32 for the time
+ # beeing since neither SGML::Parser::OpenSP nor check auto-
+ # magically set search_dirs to include the temp directory
+ # so restricted file reading would defunct the Validator.
+ $opensp->restrict_file_reading(1) unless $^O eq 'MSWin32';
#
# Set debug info for HTML report.
@@ -1352,8 +1346,7 @@
my $dtd = sub {
return if $File->{Root};
- # TODO: These \s here are probably wrong now that the strings are utf8_on
- # Same for the \w probably
+ # TODO: The \s and \w are probably wrong now that the strings are utf8_on
($File->{Root}, $File->{DOCTYPE}) = shift =~ m(<!DOCTYPE\s+(\w+)\s+(?:PUBLIC|SYSTEM)\s+(?:[\'\"])([^\"\']+)(?:[\"\']).*>)si;
};
Received on Saturday, 10 September 2005 07:06:33 UTC