- From: olivier Thereaux <ot@w3.org>
- Date: Thu, 1 May 2008 19:39:44 +0900
- To: Felix Miata <mrmazda@ij.net>
- Cc: www-validator-css@w3.org
Hello Felix,
Thank you for the patch. With my apologies for taking a bit of time to
review it, I have looked into it today.
On 26-Mar-08, at 4:08 AM, Felix Miata wrote:
> --- results0.css 2008-03-12 10:26:10.000000000 -0400
> +++ results1.css 2008-03-25 14:53:40.000000000 -0400
> @@ -66,14 +66,14 @@
> img.inline-badge {
> float: left;
> padding: 10px;
> - margin-left: 3em;
> + margin-left: 1.6em;
> }
>
> pre.badgeSnippet {
> - margin-left: 108px !important; /* give room to the image */
> - padding-left: 3em;
> - font-size: x-small;
> - color: #777;
> + margin-left: .6em !important; /* give room to the image */
> + padding-left: .6em;
> + font-size: small;
> + color: #000;
> margin-bottom: 2em;
> }
>
> @@ -173,9 +173,9 @@
>
> /* ==== example of code for icon ==== */
> pre {
> - margin-left: 30px;
> - padding: 2em;
> - border-left: thin solid #ddd;
> + margin-left: 3px;
> + padding: 2em .2em 1em;
> + background-color: #e8f0ed;
> }
I have followed parts of your patch very closely (e.g font size),
others I respectfully disagree with (making the text color stronger
than the rest of the text on the results page, for instance) and
therefore settled for a compromise patch that I hope you will find
acceptable.
The style patch can be tested at:
http://qa-dev.w3.org:8001/css-validator/
It would be great if this change to the results page could be tested
on a variety of browsers. Indeed, reports on any style bug currently
showing would be much welcome.
Thank you
--
olivier
Many thanks for your feedback and contribution.
Received on Thursday, 1 May 2008 10:40:31 UTC