Re: [blink-dev] Intent to Implement and Ship: WebAudio: Event Constructors

Definitely will add you to the CL.

One thing we forgot to mention.  With the deprecation of
ScriptProcessorNode, AudioProcessingEvent is also deprecated.  We do this
for completeness.

Also, OfflineAudioCompletionEvent is for when the offline context is
finished.  We fully expect users to use the promise instead of the
completion event.  The promise pattern is so much easier to use.

On Thu, Nov 10, 2016 at 8:09 AM, Philip Jägenstedt <foolip@chromium.org>
wrote:

> LGTM2 with the spec fixed. I wouldn't mind looking at the CL, as it's
> surprisingly easy to get things around optional dictionary arguments and
> required dictionary members wrong. In particular, any event interface that
> has non-nullable attributes of interface type, which is true of both of
> these events, need to the corresponding dictionary members as required, or
> something magical would have to happen when calling the constructor without
> them.
>
> On Thu, Nov 10, 2016 at 1:28 AM Rick Byers <rbyers@chromium.org> wrote:
>
>> Adding constructors makes sense - thanks!  But as spec'd these don't yet
>> follow the standard event construction pattern.  Filed
>> https://github.com/WebAudio/web-audio-api/issues/1067
>>
>> On Wed, Nov 9, 2016 at 2:26 PM, 'Alex Russell' via blink-dev <
>> blink-dev@chromium.org> wrote:
>>
>> Glad to see this. It's great to have platform consistency where possible.
>>
>> On Wed, Nov 9, 2016 at 1:14 PM, Chris Harrelson <chrishtr@chromium.org>
>> wrote:
>>
>> LGTM1
>>
>> On Wed, Nov 9, 2016 at 1:10 PM, 'Raymond Toy' via blink-dev <
>> blink-dev@chromium.org> wrote:
>>
>> Contact emails
>>
>> rtoy@chromium.org, hongchan@chromium.org
>>
>> Spec
>>
>> https://webaudio.github.io/web-audio-api/
>>
>> https://webaudio.github.io/web-audio-api/#OfflineAudioCompletionEvent
>>
>> https://webaudio.github.io/web-audio-api/#the-audioprocessingevent-
>> interface---deprecated
>>
>> Summary
>>
>> Add constructors for the WebAudio events.
>>
>> Motivation
>>
>> Events are generally constructable, but the two WebAudio events were
>> not.  This makes these events match the typical Event model.
>>
>> See https://github.com/WebAudio/web-audio-api/issues/566 for the spec
>> discussion.
>>
>> Interoperability and Compatibility Risk
>>
>> This is a new addition to the spec that will not affect backward
>> compatibility.  We expect all browser to implement these constructors.
>>
>> Ongoing technical constraints
>>
>> None.
>>
>> Will this feature be supported on all six Blink platforms (Windows, Mac,
>> Linux, Chrome OS, Android, and Android WebView)?
>>
>> Yes.
>>
>> OWP launch tracking bug
>>
>> http://crbug.com/662164
>>
>> Link to entry on the feature dashboard <https://www.chromestatus.com/>
>>
>> https://www.chromestatus.com/feature/5670531110010880
>>
>> Requesting approval to ship?
>>
>> Yes.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscribe@chromium.org.
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscribe@chromium.org.
>>
>>
>>
>>