[Prev][Next][Index][Thread]

Re: HTString.c : possible bug in HTNextField ?


> The following is a patch that fixes the double quote problem for me in the
> libwww 3.1 . The quoting feature with < and > seems to be similarly broken,
> but I did not try out nor fix it. I will leave this to somebody who is more
> knowledgeable about this matter, and who might know more of the history
> behind the HTNextField function, and whether my modification breaks
> something else or not.

zut - you are right! Also in that it needs to be fixed for the "<" ">" case as 
well where there is a initialization of start pointer missing

I have kind of patched you patch - hope it makes sense...
 
> --- HTString.c.~1~      Thu Jul 13 15:41:06 1995
> +++ HTString.c  Tue Oct 10 00:10:22 1995
> @@ -9,6 +9,7 @@
>  **     02-Dec-91 (JFG) Added stralloccopy and stralloccat
>  **     23 Jan 92 (TBL) Changed strallocc* to 8 char HTSAC* for VM and suchlike
>  **      6 Oct 92 (TBL) Moved WWW_TraceFlag in here to be in library
> +**      9 Oct 95 (KR)  fixed problem with double quotes in HTNextField
>  */
> 
>  /* Library include files */
@@ -177,6 +178,9 @@
             start = ++p;
             for(;*p && *p!='"'; p++)
                 if (*p == '\\' && *(p+1)) p++;         /* Skip escaped chars 
*/
 +           break;                          /* kr95-10-9: needs to stop here 
*/
         } else if (*p == '<') {                              /* quoted field 
*/
 +           start = ++p;
             for(;*p && *p!='>'; p++)
                 if (*p == '\\' && *(p+1)) p++;         /* Skip escaped chars 
*/
 +           break;                          /* kr95-10-9: needs to stop here 
*/
 
 


-- 

Henrik Frystyk Nielsen, <frystyk@w3.org>
World-Wide Web Consortium, MIT/LCS NE43-356
545 Technology Square, Cambridge MA 02139, USA