Re: Bug in HTTimer.c

Hello Jens,

Good analysis. I don't understand one thing in your patch. Is the #ifdef
related to the else block or is it done systematically, regardless of whether
the timer is repetitive:

In our previous episode, Jens Meggers said:
> 
> >    if (timer->repetitive)
> > HTTimer_new(timer, timer->cbf, timer->param, timer->millis, YES, YES);
> >    else
> > HTList_quickRemoveElement(cur, last);
> #ifdef WWW_WIN_ASYNC
>  // on windows we have to stop the timer 
>  DeletePlatformTimer(timer);
> #endif

Or should it be:

> >    if (timer->repetitive)
> > HTTimer_new(timer, timer->cbf, timer->param, timer->millis, YES, YES);
   else {
> > HTList_quickRemoveElement(cur, last);
> #ifdef WWW_WIN_ASYNC
>  // on windows we have to stop the timer
>  DeletePlatformTimer(timer);
> #endif
  }

As soon as I get your answer, I'll try your patch with Amaya and if it works
OK, I'll commit it.

Thanks,

-Jose

Received on Thursday, 27 July 2000 05:35:19 UTC