Re: FreeBSD patch for libwww

At 19:18 1/7/99 +0100, jose.kahan@w3.org wrote:
>In the Amaya list, we received some patches for compiling Amaya under
>FreeBSD. One of those patches concerns libwww:

I like the #ifndef O_SYN better - so what about

#ifdef O_SYNC
#define OPEN_FLAGS	O_WRONLY|O_CREAT|O_TRUNC|O_SYNC
#else
#define OPEN_FLAGS	O_WRONLY|O_CREAT|O_TRUNC
#endif

As a total replacement?

You are more than welcome to commit this!

Henrik

>======================
>Second is a small patch to the libwww sources.  If you hear from users
>of any other O_SYNC deprived OSen, it might be more efficient to just
>say #ifndef O_SYNC.
>
>--- libwww/Library/src/HTMemLog.c.orig	Wed Dec 16 11:55:44 1998
>+++ libwww/Library/src/HTMemLog.c	Tue Jan  5 20:13:09 1999
>@@ -15,7 +15,7 @@
> #include "HTMemLog.h"
> #include "HTTimer.h"
> 
>-#ifdef WWW_MSWINDOWS
>+#if defined(WWW_MSWINDOWS) || defined (__FreeBSD__)
> #define OPEN_FLAGS	O_WRONLY|O_CREAT|O_TRUNC
> #else /* WWW_MSWINDOWS */
> #define OPEN_FLAGS	O_WRONLY|O_CREAT|O_TRUNC|O_SYNC
>
>-- 
>
>=====================
>
>Has anyone else had this problem before? 
>Does anyone object if we add this modif directly to the CVS base?
>
>Thanks,
>
>-Jose
>
--
Henrik Frystyk Nielsen,
World Wide Web Consortium
http://www.w3.org/People/Frystyk

Received on Thursday, 7 January 1999 13:39:15 UTC