Re: bug in HTHost_decreaseRetry ???

: I just started working with this code base and am unsure about where the
: patches are.  I noticed one collection on the website.  I'm assuming
: that 5.1b has all the patches applied from 5.1a.

 I hope that in some future time someone at W3C will find the time
 to collect the patches sent to this list. For now, it seems to me
 that you have to check the patches yourself.

: Version 5.1b ....
: The code in HTHost_decreaseRetry looks wrong, and causes an infinite
: loop in HTDoConnect.  Notice that the host->retry count doesn't get
: decreased unless host is NULL which would normally cause an access
: violation anyway :( 
: 
: Suggest  the ! should be removed from !host.
: 
: PUBLIC BOOL HTHost_decreaseRetry (HTHost * host)
: {
:     if (!host) {
: 	if (host->retry > 0) host->retry--;
: 	return YES;
:     }
:     return NO;
: }

yes, or if you change the structure a little, this function will look like the
other HTHost_ functions:
  
PUBLIC BOOL HTHost_decreaseRetry (HTHost * host)
{
    if (!host) return NO;
    if (host->retry > 0) host->retry--;
    return YES;
}

Unfortunately, HTHost.c does not seem to be sufficiently debugged.
In some of my leisure hours i am trying to track down some bugs when
running requests are killed (using HTRequest_kill, multiple pipelined
requests)

best regards,
-gustaf neumann
--
Wirtschaftsinformatik und Softwaretechnik        
Universitaet GH Essen, FB5
Altendorfer Strasse 97-101, Eingang B, D-45143 Essen
Tel.: +49 (0201) 81003-74, Fax:  +49 (0201) 81003-73
Gustaf.Neumann@uni-essen.de
http://nestroy.wi-inf.uni-essen.de/Neumann.html

Received on Friday, 13 June 1997 15:52:36 UTC