New DirectoryResource (bug???)

Hi,

I installed new(patched) DirectoryResource and the new behavior that should
have fixed index file problems now seem to generate side effects that are
very undesirable.

For easy example try to point to /Admin/Editor/User/. Originally, it was
bringing up the content of User directory and allow me to add/remove
resources and modify attributes. Now, however, it takes me directly to
Overview.html resource instead.

I know why this happens and I don't like it a little bit. It happens
because new lookup method of DirectoryResource returns index file if it
exist. That works ok when user points to the directory, but when editor or
filter or anything else try to reach the directory itself, they are out of
luck.

This means, that once you setup an index file for directory, it is not
accessible anymore.

This is a serious bug in my opinion and has to be fixed before many people
use the patch.

I found a quick fix, but I am not sure if it breaks anything else.
Basically, it checks if the request is internal and if it is does not
continue lookup into index file.

If anybody knows all the internal constrains on internal vs. external
requests maybe you can check if this breaks anything else.

The fix is to change the line 663 of lookup() routine in patched
DirectoryResource
from
if (index != null ) {
to
if ( !ls.isInternal() && index != null ) {

I would be very happy if somebody could explain to me how exactly internal
requests are different from normal once, especially regarding filters
execution/lookups/etc.

Also, if from resource /foo/res1 I do internal request to /foo/res2
starting at the top how would that be different for filters from /foo/res1
doing 302 redirect for client to /foo/res2?

Hope it helps,
     Alex.

--------| I feel as confused as a baby in a topless bar. |--------

Received on Friday, 25 October 1996 07:02:57 UTC