Re: [amaya-dev]Re: More questions abour the build system

Hi,

On Thu, November 9, 2006 15:24, Irene Vatton said:
>> Wouldn't it make more sens to change the Amaya source code to follow the
>> new API in this case ? IT would make you benefit from improvements and
>> bug fixes from the library. Plus, it makes less code for you to
>> maintain. I had a quick look, changes don't seem very intrusive.
>
> You're probably rigth but I need time to have a look at raptor & redland
> libraries.

When I tried building against the shared one, I only had errors with two
symbols :
-one which was made internal (which is probably wrong, as it is referenced
nowhere else in the library source code)
-a function pointer definition changed from returning a void to returning
an int.

>> The attached dont_use_constructor.diff patch removes a useless call to
>> librdf_serializer_rdfxml_constructor(), which is already called
>> indirectly by librdf_world_open() including in the version you provide,
>> so it can be safely applied. This only leaves 2 issues with the latest
>> version of librdf.
>
> I needed to add this line in configure.in to be able to compile my version
> :
> + AC_SUBST(MAKERAPTOR)
>   AC_SUBST(MAKEREDLAND)

I had a quick look at what is in the CVS. The reason is worked for me was
beacause my cleanup patch also removed the raptor build system. It is now
useless, as the raptor lib is built within the rdf one. Plus, the
libraptor/libraptor.a file is never linked against anyway.

If I have some time this evening. Could you confirm that removing the
$(LIBRAPTOR) from EXTRA_SUBDIRS in Makefile.in doesn't make the build fail
?

I will submit a patch reintroducing the raptor build later, in a different
and more modular way.

> I also use the opportunity to remove NOPRINT and PRINTIFNOTGL options as
> they
> are not necessary today. If you've access to our CVS base, you may have a
> look at the new version.

Thanks for applying my patches. More will come when I have time to
correctly work on them.

Regis

Received on Thursday, 9 November 2006 16:24:57 UTC