Re: Reviewing pull request for CfC

Github doesn’t make this too easy. Here’s what I’m seeing that might help:

The table rows reflect the line numbers that have changes. The rows that are highlighted are:
First file/table
470, 471
Next file/table
2, 8, 9, 10
Next file/table
1-9 (deletes whole file)
Last file/table

When I do a text search I can find the additions by searching for “+ “ in the browser. I can almost do the same for the deletions, but in some cases there isn’t a space after the “-“ that indicates that the markup will be removed, and searching for the dash without a space isn’t a helpful search.

I don’t see any good labels to otherwise search for. We should make a recommendation to GitHub – they have been quite responsive in the past.


Andrew Kirkpatrick
Group Product Manager, Accessibility

From: "White, Jason J" <<>>
Date: Friday, September 29, 2017 at 10:22
To: WCAG <<>>
Subject: Reviewing pull request for CfC
Resent-From: WCAG <<>>
Resent-Date: Friday, September 29, 2017 at 10:23

I’m having difficulty reviewing the tables on GitHub in which the source code is presented of the pull request currently under review in the CfC.

Is there a way to obtain a plain text diff patch of the change, or another textual format which would be easier to read and review?


This e-mail and any files transmitted with it may contain privileged or confidential information. It is solely for use by the individual for whom it is intended, even if addressed incorrectly. If you received this e-mail in error, please notify the sender; do not disclose, copy, distribute, or take any action in reliance on the contents of this information; and delete it from your system. Any other use of this e-mail is prohibited.

Thank you for your compliance.


Received on Friday, 29 September 2017 14:52:59 UTC