W3C home > Mailing lists > Public > w3c-ietf-xmldsig@w3.org > April to June 2001

Comments for CR-xmldsig-core-20010419

From: Susan Lesch <lesch@w3.org>
Date: Sat, 19 May 2001 19:02:05 -0700
Message-Id: <p05100301b72cd55b0f82@[24.25.223.38]>
To: dee3@torque.pothole.com, reagle@w3.org, dsolo@alum.mit.edu
Cc: w3c-ietf-xmldsig@w3.org
These are very minor comments for your XML Signature Candidate
Recommendation [1]. This is a densely technical specification. No words
are wasted and it is really well done. I hope to read it one last time
for typos if and when it reaches Proposed Recommendation.

The bottom part of this GIF seems to be cut off.
http://www.w3.org/TR/2001/CR-xmldsig-core-20010419/xmldsig-datamodel-20000112.gif
Also, a white, rather than transparent background, would help people
with user style sheets set to light on dark.

There are 8 examples marked up <p class="xml-example"> and one <p
class="xml-dtd"> containing things like: &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;.
You might make these <pre class="xml-example"> and <pre
class="xml-dtd"> like the others. This may mean removing some br's.

 From here down, a section number is followed by a quote and then a
suggestion.

1.1 par. 1
section 8.3 .)
section 8.3.)

1.1 par. 2
XML Schemas
XML schemas, or XML Schema

4.2 par. 1
While we specify a mandatory... SignatureMethod algorithms
While we specify mandatory... SignatureMethod algorithms
or, While we specify a mandatory... SignatureMethod algorithm

4.3.1 par. 3 list item 1
an <a href="#ref-XPath">XPath</a> node-set
an XPath [<a href="#ref-XPath">XPath</a>] node-set

4.3.1 par. 4
[XML-C14N] needs a link

4.3.3.1 par. 2
such as a HTTP cookies
such as HTTP cookies

4.3.3.2 pars. 5-7
URI-Reference
URI reference (In RFC 2396 this is the most common form, and I'd use it unless
referring to the BNF construct itself.)

4.4 par. 3
it's
its

4.4.4 list item 1
You might want to spell out iff, if that's what is meant.

4.5 last par.
vice-versa
vice versa

6.1 par. 2
the mechanism is extensible, alternative algorithms may
the mechanism is extensible; alternative algorithms may

6.5 par. 1
two implicit parameter
two implicit parameters

6.6.1 needs an ending full stop.

8.1.3 (A user is usually a person.)
Just as a user should only sign what it "sees,"
Just as a user agent should only sign what it "sees,"
or
Just as a user should only sign what they "see," (or, he or she "sees")

[1] http://www.w3.org/TR/2001/CR-xmldsig-core-20010419/

Best wishes for your project,

Susan Lesch - mailto:lesch@w3.org  tel:+1.858.483.4819
World Wide Web Consortium (W3C) - http://www.w3.org/
Received on Saturday, 19 May 2001 22:02:11 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 20:10:04 UTC