Re: Automatic diffs for PRs

This make the spec much more easy to read ! Thanks for this, Norm !
Christophe

Le 09/10/2022 à 13:58, Norm Tovey-Walsh a écrit :
> Hi folks,
>
> As some of you may have noticed from the burst of commits, pull
> requests, and merges, I’ve been working on generating automatic diffs
> using DeltaXML (who very generously provide an XML Compare license for
> this purpose).
>
> I believe it is now working, as you can see in this example:
>
>    https://qt4cg.org/pr/194/xpath-functions-40/autodiff.html
>
> It doesn’t apply to any branches or pull requests that already exist, so
> we won’t see it ‘in action’ until the next and following PRs.
>
> I added a bit of explanation about the process:
>
>    https://qt4cg.org/deltaxml.html
>
> This is not intended as a replacement for change markup provided by the
> editors (so, no, editors, you can’t stop doing that!), but as an adjunct
> to aid in review.
>
> I have been wanting to implement the “go to next diff” feature for years
> and I hope it turns out to be useful.
>
> (If you have your own DeltaXML license and wish to steal that feature,
> it’s in https://qt4cg.org/js/scroll.js; note that I’ve replaced the JS
> for all of the buttons, not just the new ones. Also note that there’s
> some special casing in there to skip change markup in the ToC. I found
> that if there were multiple scrolling regions, window.scrollTo() didn’t
> work consistently, so I avoided any targets in the ToC scrolling view.
> It’s probably possible to do better. Also note that I avoided
> Element.scrollIntoView(), which does work for all scrolling regions,
> because that puts the scrolled item at the very top of the page where
> it’s, annoyingly, behind the buttons!)
>
>                                          Be seeing you,
>                                            norm
>
> --
> Norm Tovey-Walsh
> Saxonica

Received on Monday, 10 October 2022 06:25:07 UTC