Comments on the Editor's Draft 14 April 2008

Hi all,

These are my comments on the latest draft (14 April):

Missing (or forgotten) texts, typos:

- 2.6.3.6 (p:resolve-uri)
Copy/paste error: the second form of the function should be
'p:resolve-uri', not 'p:base-uri'

- 7.1.11 (p:insert)
I think that "in which case multiple copies of the insertion document
will occur" should read "in which case multiple copies of the insertion
documentS will occur". Plus perhaps also mention that if the 'insertion'
input port contains an empty sequence of documents, nothing is inserted.

- 7.1.12 (p:label-elements)
Typo: "must bind the variable '>p:index' in..."

- 7.2.2 (p:hash), 7.2.3 (p:uuid)
There are still some forgotten TBDs there

- 7.2.5 (p:validate-with-schematron)
Forgotten FIXME

- 7.2.9 (p:xquery)
Describe what the parameter input on this step is used for (propably for
passing parameters to the XQuery)
Typo: "The query> port..."


General comments/questions:

- 7.1.12 (p:label-elements) 
The default value of the option 'label' contains explicit reference to
'$p:index'. What if the prefix 'p' is not bound in the pipeline? For
example:

<x:pipeline xmlns:x="http://www.w3.org/ns/xproc">
  <x:label-elements/>
</x:pipeline>

In case like this, the default expression for label cannot be evaluated
because 'p' is not bound to any namespace.

- 7.1.6 (p:directory-list)
Shouldn't the option 'path' be renamed to 'href' so it is more
consistent with other steps?

- Relative URIs in option values:
7.1.6 (p:directory-list) says: "The value of the path option must be an
anyURI. It is interpreted as an IRI reference. If relative, it is
resolved to absolute form. The base URI used for resolution is the base
URI of p:option element, if present, otherwise, that is in case the
default of '.' is used, the base URI of the p:directory-list element."

I think there should be a similar statement for each step that accepts
options that represent external URIs (p:load, p:store, p:xsl-formatter;
what about 'output-base-uri' on p:xslt?), and perhaps also for p:import,
p:document, p:log.


Regards,
Vojtech

--
Vojtech Toman
Principal Software Engineer
EMC Corporation

Aert van Nesstraat 45
3012 CA Rotterdam
The Netherlands

Toman_Vojtech@emc.com

Received on Wednesday, 16 April 2008 14:56:12 UTC