W3C home > Mailing lists > Public > whatwg@whatwg.org > November 2013

Re: [whatwg] Comments on <dialog>

From: Matt Falkenhagen <falken@chromium.org>
Date: Sun, 3 Nov 2013 11:59:49 +0900
Message-ID: <CAJ_xCi=ognpV1fXmar3R_oCe5g1+0F1xtp6UBLe5g95oYAC2eg@mail.gmail.com>
To: Ian Hickson <ian@hixie.ch>
Cc: WHATWG <whatwg@lists.whatwg.org>, Ojan Vafai <ojan@chromium.org>
On Fri, Sep 27, 2013 at 7:15 AM, Ian Hickson <ian@hixie.ch> wrote:

> On Mon, 26 Aug 2013, Matt Falkenhagen wrote:
> > Changing the static position after layout breaks much assumptions in the
> > code and would seem to require invasive work across the render tree,
> > layer tree, possibly painting, etc. In contrast, if CSS is manipulated
> > after the first layout pass, the layout engine just works. So I found it
> > convenient and stable to mutate CSS 'top' directly.
>
> I don't think mutating attributes is a sane approach to doing this. It
> feels like a hack, it interferes with author affordances, it makes it
> harder for us to distinguish script-set property values from UA-set
> property values, it makes it harder for authors to specifically override
> the UA, etc.
>

I changed this in Blink to match the spec. Now dialog centering sets the
static position instead of the computed 'top' value.
Received on Sunday, 3 November 2013 03:00:33 UTC

This archive was generated by hypermail 2.4.0 : Wednesday, 22 January 2020 17:00:13 UTC