W3C home > Mailing lists > Public > whatwg@whatwg.org > November 2013

Re: [whatwg] Proposal: Adding methods like getElementById and getElementsByTagName to DocumentFragments

From: Kang-Hao (Kenny) Lu <kanghaol@oupeng.com>
Date: Sun, 03 Nov 2013 06:32:08 +0800
Message-ID: <52757D68.7030100@oupeng.com>
To: Boris Zbarsky <bzbarsky@MIT.EDU>, Anne van Kesteren <annevk@annevk.nl>
Cc: Glenn Maynard <glenn@zewt.org>, "Tab Atkins Jr." <jackalmage@gmail.com>, Ryosuke Niwa <rniwa@apple.com>, whatwg <whatwg@lists.whatwg.org>, Tim Streater <tim@clothears.org.uk>, Ian Hickson <ian@hixie.ch>
(2013/11/02 9:59), Boris Zbarsky wrote:
> I can obviously adjust our in-tree tests, but this test was part of
> jQuery's regression test suite, and I would be slightly surprised if
> there's no one out there using jQuery 1.2.6 (or later, up until the code
> went away; I did check that jQuery 1.10.2 no longer has the code cited
> above) and if they don't run into this issue.  :(

Not that I am very familar with jQuery's history, but the cited code
seems to be pre-Sizzle selector implemention[1], and therefore 1.2.6
should be the last jQuery version with this bug.

I assume Mozilla testsuite means that getElementById on elements are
roughly compatibile with jQuery 1.3+ even if they are actually using
those[2]. That's pretty lucky, I think :) It would still be a good idea
to run the lastest tests in Sizzle with jQuery 1.3 with the
getElementById on elements impmentation to see if there's breakage, but
my guess is no.

[1] The exact change seems to be this one
https://github.com/jquery/jquery/commit/c85243dfc4b09e6bb87532f2025f686b6ae45a22
[2] https://github.com/jquery/jquery/blob/1.3/src/selector.js#L343




Cheers,
Kenny
-- 
Web Specialist, Opera Sphinx Game Force, Oupeng Browser, Beijing
Try Oupeng: http://www.oupeng.com/
Received on Saturday, 2 November 2013 22:32:35 UTC

This archive was generated by hypermail 2.4.0 : Wednesday, 22 January 2020 17:00:13 UTC