- From: Rik Cabanier <cabanier@gmail.com>
- Date: Tue, 29 Jan 2013 21:55:16 -0800
- To: Boris Zbarsky <bzbarsky@mit.edu>
- Cc: WHATWG <whatwg@lists.whatwg.org>, "Tab Atkins Jr." <jackalmage@gmail.com>
On Tue, Jan 29, 2013 at 9:49 PM, Boris Zbarsky <bzbarsky@mit.edu> wrote:
> On 1/30/13 12:37 AM, Rik Cabanier wrote:
>
>> enum CanvasMaskType { luminosity, alpha};
>>
>
> Last nits. Need quotes around the enum values. So:
>
> enum CanvasMaskType { "luminosity", "alpha" };
>
> void maskImage(MaskOptions options);
>>
>
> I believe that has to be:
>
> void maskImage(optional MaskOptions options);
>
Why is it optional?
It's not optional for 'addHitRegion' in the spec either...
>
> to be valid WebIDL.
>
> Apart from that, the IDL parts look fine. Can't speak to the actual
> graphics bits. ;)
>
> -Boris
>
>
Received on Wednesday, 30 January 2013 05:55:40 UTC