W3C home > Mailing lists > Public > whatwg@whatwg.org > April 2013

[whatwg] Comments on <dialog>

From: Matt Falkenhagen <falken@chromium.org>
Date: Mon, 22 Apr 2013 13:35:45 +0900
Message-ID: <CAJ_xCi=dZeocSKh=okFnwVfq15PfXQUNsrtOxLQ4Y1yyM_wQdg@mail.gmail.com>
To: whatwg@lists.whatwg.org
I've been working on implementing <dialog> for Blink. Here are some
questions and feedback.

1. Browsers that don't support <dialog> will show the content by
default, unlike browsers that do. Should the spec be changed to make
dialogs open by default (and use a "closed" instead of "open"
attribute)? Or is there another easy way to degrade gracefully for
older browsers?

2. Would naming the methods open/close or show/hide instead of
show/close be more natural?

3. For centering in the viewport, the spec mandates that the used
value of 'top' be specially calculated. I found it more convenient to
implement by mutating the computed value rather than the used value.
This has the added benefit that it's straightforward for the page
author to implement dragging using getComputedStyle.

4. Why isn't the dialog horizontally centered in the viewport? The
spec just mentions vertical centering and 'top'.

5. For centering, the spec may need to be more detailed about what
happens in different writing modes. Probably we want to center
horizontally in vertical writing mode, in which case we don't set
'top'.

6. If I understand the spec correctly, a dialog doesn't escape its
iframe and particularly a modal dialog in an iframe doesn't block the
iframe's parent browsing context's document. Is that accurate? I
wonder if there are use cases we should support for escaping an iframe
(perhaps just seamless ones).
Received on Monday, 22 April 2013 04:36:30 UTC

This archive was generated by hypermail 2.4.0 : Wednesday, 22 January 2020 16:59:57 UTC