- From: Rik Cabanier <cabanier@gmail.com>
- Date: Thu, 18 Apr 2013 19:51:38 -0700
- To: "Tab Atkins Jr." <jackalmage@gmail.com>
- Cc: Justin Novosad <junov@google.com>, WHAT Working Group <whatwg@whatwg.org>
On Thu, Apr 18, 2013 at 6:38 PM, Tab Atkins Jr. <jackalmage@gmail.com>wrote: > On Thu, Apr 18, 2013 at 4:42 PM, Rik Cabanier <cabanier@gmail.com> wrote: > > On Thu, Apr 18, 2013 at 4:18 PM, Tab Atkins Jr. <jackalmage@gmail.com> > > wrote: > >> On Thu, Apr 18, 2013 at 3:40 PM, Rik Cabanier <cabanier@gmail.com> > wrote: > >> > I think that all enumerated DOMStrings in CanvasDrawingStyles should > >> > move > >> > to enums. This seems cleaner and have no compatibility issues. > >> > However, if we keep them as DOMStrings, I agree that textDecoration > >> > should > >> > be one too. > >> > >> If they're trying to take on the value of CSS properties, they should > >> absolutely *not* be enums. DOMStrings are the correct data type for > >> that. > > > > Why is that? There's no difference to an author. > > There is, the moment you have a multi-keyword value. ^_^ > > (Also, it lets you more easily just defer to CSS for the > interpretation of the property, rather than having to manually update > the enum when we add new values.) I checked and the values in CanvasDrawingStyles don't correspond with CSS values so it should be OK to turn them into enums. Only 'font' corresponds to an actual CSS value [1] and must not be changed. The proposed 'textDecoration' property would follow CSS so it *could* be a DOMString (even though I feel the IDL is cleaner with enums). 1: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-font
Received on Friday, 19 April 2013 02:52:03 UTC