- From: Glenn Maynard <glenn@zewt.org>
- Date: Fri, 28 Oct 2011 17:03:53 -0400
On Fri, Oct 28, 2011 at 4:55 PM, Ojan Vafai <ojan at chromium.org> wrote:
> I agree in general. Changing add/remove is definitely worth doing. In the
> case of toggle, WebKit already returns a boolean. Returning the
> DOMTokenList
> is clearly preferable IMO. It's a new enough API that maybe the web doesn't
> yet depend on the return value of toggle?
>
The return value of toggle() seems more useful than chaining.
if(foo.toggle("purple"))
alert("now purple");
else
alert("no longer purple");
This is preferable to me over the following, because the token ("purple")
doesn't have to be duplicated:
foo.toggle("purple");
if(foo.has("purple"))
...
--
Glenn Maynard
Received on Friday, 28 October 2011 14:03:53 UTC