W3C home > Mailing lists > Public > whatwg@whatwg.org > October 2011

[whatwg] DOMTokenList methods would be more useful with a space separated token list

From: Glenn Maynard <glenn@zewt.org>
Date: Fri, 28 Oct 2011 17:03:53 -0400
Message-ID: <CABirCh8-6YLvEB4rk3861RczVUcpW7-So7oE_F07+q0AY7Da6A@mail.gmail.com>
On Fri, Oct 28, 2011 at 4:55 PM, Ojan Vafai <ojan at chromium.org> wrote:

> I agree in general. Changing add/remove is definitely worth doing. In the
> case of toggle, WebKit already returns a boolean. Returning the
> DOMTokenList
> is clearly preferable IMO. It's a new enough API that maybe the web doesn't
> yet depend on the return value of toggle?
>

The return value of toggle() seems more useful than chaining.

if(foo.toggle("purple"))
    alert("now purple");
else
    alert("no longer purple");

This is preferable to me over the following, because the token ("purple")
doesn't have to be duplicated:

foo.toggle("purple");
if(foo.has("purple"))
    ...

-- 
Glenn Maynard
Received on Friday, 28 October 2011 14:03:53 UTC

This archive was generated by hypermail 2.4.0 : Wednesday, 22 January 2020 16:59:37 UTC