W3C home > Mailing lists > Public > whatwg@whatwg.org > May 2011

[whatwg] Proposal to remove a paragraph from canvas spec

From: Matthew Delaney <mdelaney@apple.com>
Date: Tue, 03 May 2011 19:08:24 -0700
Message-ID: <D2E08C12-27F2-499A-B32D-B8F7AB767FCB@apple.com>
The paragraph in the canvas spec that reads...
"Shadows are only drawn if the opacity component of the alpha component of the color of shadowColor is non-zero and either the shadowBlur is non-zero, or the shadowOffsetX is non-zero, or the shadowOffsetY is non-zero."
?I've found must have been modeled after a bug originally from CoreGraphics. As you can see in this simple animation of a shadow blur being reduced from 20 down to 0, this "edge case" outlined in the above paragraph produces undesirable behavior at the end of the animation: http://webstuff.nfshost.com/shadowblur.html

This outlined edge case really only affects a particular case of when the composite operation is set to destination-atop, which should result in the shadow landing "on top of" its source, and both the offsets and blur are of course 0. In the animation sample linked above, this case is the end state of the animation (the rect turning all blue all of a sudden).

1) This behavior is obviously not ideal (see the linked animation above) and is really just a bug
2) I can't imagine this particular edge case popping up all that often (think: using destination-atop and having both the shadow offsets and the blur 0 so that the shadow would otherwise be totally eclipsed by the source?)
3) The only major browsers I've found to support this edge case are Firefox4 (but not versions less than 4) and CG/Skia ports of WebKit browsers (because this is where the bug originated)
...I'm proposing this:
1) Strip out this edge case paragraph in the spec (yay, cleaner spec!)
2) Notify Firefox team that they should strip out this hack in their code for the edge case.
3) Quickly fix WebKit ports
4) File a bug against CG on this faulty behavior (just did that) and hope that it can be fixed in future releases.
5) Ask philip/W3C nicely to update his/the test at http://philip.html5.org/tests/canvas/suite/tests/2d.shadow.enable.off.2.html / http://w3c-test.org/html/tests/approved/canvas/2d.shadow.enable.off.2.html

I also posted more info here: https://bugs.webkit.org/show_bug.cgi?id=60091

I realize this is somewhat nit-picky, but it's clearly a bug (unless I'm missing something obvious) that I think we can all quickly rectify. Additionally, I've found a handful of other similar things in the canvas spec that I will write about shortly, but wanted to test the waters of emailing this list first to see how hard it is to push this "easier" issue. ;-)

--Matt Delaney
Received on Tuesday, 3 May 2011 19:08:24 UTC

This archive was generated by hypermail 2.4.0 : Wednesday, 22 January 2020 16:59:32 UTC