Re: [openscreenprotocol] Add capabilities (#140)

@mfoltzgoogle, thoughts on closed comments below. TL;DR I believe I have addressed all of your comments in my other patch,
https://github.com/webscreens/openscreenprotocol/pull/154

**https://github.com/webscreens/openscreenprotocol/pull/140#discussion_r272304956**
"Codecs should be generic":
_Agreed, cleaned up in second patch._

**https://github.com/webscreens/openscreenprotocol/pull/140#discussion_r272308357**
"Codecs belong in streaming":
_Agreed, moved as part of moving to second patch._

**https://github.com/webscreens/openscreenprotocol/pull/140#discussion_r272308928**
"Rational number":
_Makes sense. Added a new ratio type, since we don't appear to have one._

**https://github.com/webscreens/openscreenprotocol/pull/140#discussion_r272309518**
"Multiple native resolutions":
_Agreed, I updated to add a : native-resolutions (optional) field._

-- 
GitHub Notification of comment by baylesj
Please view or discuss this issue at https://github.com/webscreens/openscreenprotocol/pull/140#issuecomment-490698578 using your GitHub account

Received on Thursday, 9 May 2019 00:25:52 UTC