[webrtc-extensions] Can we rename setSelectedCandidatePair to selectCandidatePair ? (#178)

jan-ivar has just created a new issue for https://github.com/w3c/webrtc-extensions:

== Can we rename setSelectedCandidatePair to selectCandidatePair ? ==
Sorry for not catching this in review, but...

Is it too late to rename setSelectedCandidatePair to selectCandidatePair ?

Using the right verbs often helps when defining methods.

Also, "setFoo" methods are a bit of an anti-pattern I deel (they beg the question of whether something should have been a setter (attribute) instead.

cc @sam-vi 

Please view or discuss this issue at https://github.com/w3c/webrtc-extensions/issues/178 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Friday, 27 October 2023 20:15:31 UTC