[webrtc-encoded-transform] Underspecified rid checking in sender.generateKeyFrame(["x"]); shouldn't throw NotAllowedError (#192)

jan-ivar has just created a new issue for https://github.com/w3c/webrtc-encoded-transform:

== Underspecified rid checking in sender.generateKeyFrame(["x"]); shouldn't throw NotAllowedError ==
The [spec](https://w3c.github.io/webrtc-encoded-transform/#abstract-opdef-generate-key-frame-algorithm) says _"If rid is defined, validate its value. If invalid, reject promise with [NotAllowedError](https://webidl.spec.whatwg.org/#notallowederror) and abort these steps."_ E.g.
```js
await sender.generateKeyFrame(["riddlemethis!"]); // throws NotAllowedError
```

Two problems:
 1. What does "invalid" mean?
     - A: not conforming _"to the grammar requirements specified in Section 10 of [[RFC8851](https://w3c.github.io/webrtc-pc/#bib-rfc8851)]"_ (like in [webrtc-pc](https://w3c.github.io/webrtc-pc/#dfn-addtransceiver-sendencodings-validation-steps))?
     - B: doesn't match any existing rid value in this sender's [[[SendEncodings]]](https://w3c.github.io/webrtc-pc/#dfn-sendencodings)?
 2. ["NotAllowedError"](https://webidl.spec.whatwg.org/#notallowederror) wrongly implies a user permission error.

My picks would be B and either `TypeError` or `InvalidAccessError` for consistency with webrtc-pc.




Please view or discuss this issue at https://github.com/w3c/webrtc-encoded-transform/issues/192 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Wednesday, 28 June 2023 19:46:28 UTC