W3C home > Mailing lists > Public > public-webrtc@w3.org > February 2018

Fwd: [w3c/web-platform-tests] Rewrite RTC ICE and DTLS transport tests with alternative dependencies (#9424)

From: Alexandre GOUAILLARD <agouaillard@gmail.com>
Date: Fri, 9 Feb 2018 20:21:40 -0800
Message-ID: <CAHgZEq6oQZx7=mph4W_hA=3aTa74WjU8nrQfdejGKcG+1BE0pg@mail.gmail.com>
To: "<public-webrtc@w3.org>" <public-webrtc@w3.org>
As promised,
WPT webrtc test dependencies problems are being addressed.

If you see anything improvable, please participate (constructively) in the
review process below, or forever hold your peace.

regards,

Dr. Alex.


---------- Forwarded message ----------
From: Soares Chen <notifications@github.com>
Date: Wed, Feb 7, 2018 at 2:07 AM
Subject: [w3c/web-platform-tests] Rewrite RTC ICE and DTLS transport tests
with alternative dependencies (#9424)
To: w3c/web-platform-tests <web-platform-tests@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>


Fixes #9110 <https://github.com/w3c/web-platform-tests/issues/9110> and
#9111 <https://github.com/w3c/web-platform-tests/issues/9111>.

This PR rewrites the tests for RTCDtlsTransport and RTCIceTransport to have
separate tests for getting the transports from both RTP sender/receiver and
SCTP transport. The common parts of the assertions are factored out into
separate functions so that they can be tested in multiple test cases.

I have tried to write the tests as dependency-neutral as possible, and test
this specifically on Microsoft Edge 42.17083. However there are still some
issues that cause the tests to still fail on Edge:

   -

   The RTCPeerConnection() constructor on Edge is non compliant and require
   minimally new RTCPeerConnection({ iceServers: [] }) to work. On my
   Windows machine none of the WPT WebRTC tests that use new
   RTCPeerConnection() would pass. I made local modification to all
   constructors so that the tests can at least run on Edge locally.
   -

   Edge only supports the legacy addStream() method and not addTrack() and
   addTransceiver(). I have specifically added a addTrackOrTransceiver()
   helper function that calls either addTransceiver(), addTrack(), or even
   addStream() so that we can continue testing the higher level features.
   -

   Edge does not implement getSenders() and getReceivers(). This makes it
   impossible to retrieve the RTCRtpSender and RTCRtpReceiver instances so
   that we can get the DTLS and ICE transport objects. The workaround of
   getting hold of an RTCRtpSender using addTrack() also does not work,
   because Edge only implements addStream() which returns only undefined.

So despite my best effort I am unable to tweak the tests to pass on any of
the current browsers. :( (perhaps the methodology also doesn't feel right)

If there are internal builds of browsers that have implemented the new
features, please do run the tests and feedback on the test result is
appreciated.
------------------------------
You can view, comment on, or merge this pull request online at:

  https://github.com/w3c/web-platform-tests/pull/9424
Commit Summary

   - Decouple dependencies for RTCIceTransport tests
   - Rewrite ICE and DTLS transport tests with alternative dependencies
   - Add in comments
   - Refactor RTCIceTransport tests

File Changes

   - *M* webrtc/RTCDtlsTransport-getRemoteCertificates.html
   <https://github.com/w3c/web-platform-tests/pull/9424/files#diff-0> (140)
   - *M* webrtc/RTCIceTransport.html
   <https://github.com/w3c/web-platform-tests/pull/9424/files#diff-1> (189)
   - *M* webrtc/RTCPeerConnection-helper.js
   <https://github.com/w3c/web-platform-tests/pull/9424/files#diff-2> (25)
   - *A* webrtc/RTCTransport-helper.js
   <https://github.com/w3c/web-platform-tests/pull/9424/files#diff-3> (193)
   - *M* webrtc/tools/.eslintrc.js
   <https://github.com/w3c/web-platform-tests/pull/9424/files#diff-4> (17)

Patch Links:

   - https://github.com/w3c/web-platform-tests/pull/9424.patch
   - https://github.com/w3c/web-platform-tests/pull/9424.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/w3c/web-platform-tests/pull/9424>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAT1nm06aJyeKQ1Z1Pzj96cFb-i4-3uOks5tSXX5gaJpZM4R8cdx>
.



-- 
Alex. Gouaillard, PhD, PhD, MBA
------------------------------------------------------------
------------------------
President - CoSMo Software Consulting, Singapore
------------------------------------------------------------
------------------------
sg.linkedin.com/agouaillard

   -
Received on Saturday, 10 February 2018 04:22:04 UTC

This archive was generated by hypermail 2.3.1 : Saturday, 10 February 2018 04:22:05 UTC