W3C home > Mailing lists > Public > public-webrtc@w3.org > February 2017

[webrtc-pc] Don't fire events on a closed peer connection

From: jan-ivar via GitHub <sysbot+gh@w3.org>
Date: Thu, 09 Feb 2017 16:50:07 +0000
To: public-webrtc@w3.org
Message-ID: <issues.opened-206561265-1486659003-sysbot+gh@w3.org>
jan-ivar has just created a new issue for 
https://github.com/w3c/webrtc-pc:

== Don't fire events on a closed peer connection ==
To avoid this, whenever we *"Queue a task to run the following 
steps:"*, we immediately do:

 * If connection's [[isClosed]] slot is true, abort these steps.

We've adopted this approach, but we're not consistent. I found at 
least a couple of places where we don't do this:

 * The negotiationneeded event (we check [[needNegotiation]], but not 
[[isClosed]] 
[here](https://w3c.github.io/webrtc-pc/#dfn-update-the-negotiation-needed-flag)).
 * Resolve promise in 
[replaceTrack](https://w3c.github.io/webrtc-pc/#dom-rtcrtpsender-replacetrack).

There may be more places.

Please view or discuss this issue at 
https://github.com/w3c/webrtc-pc/issues/1020 using your GitHub account
Received on Thursday, 9 February 2017 16:50:13 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 15:19:50 UTC