Re: Proposal for RtpSender.getParameters and .setParameters from Martin Thomson on 2014-11-03 (public-webrtc@w3.org from November 2014)

From: Martin Thomson <martin.thomson@gmail.com>
Date: Mon, 3 Nov 2014 15:15:23 -0800
To: Peter Thatcher <pthatcher@google.com>
Cc: "public-webrtc@w3.org" <public-webrtc@w3.org>
Message-ID: <CABkgnnUP4qhiym8=FHM2RbpAYexqjE=6QqXNNaQ7kLspjHUdkQ@mail.gmail.com>

On 3 November 2014 13:16, Peter Thatcher <pthatcher@google.com> wrote:
>  RTCRtpParameters getParameters();

getCurrentParameters(); ?

>     unsigned long maxBitrate = null;

Don't assign a default to this one.  Presence of absence can be used
as a signal (and defaults ruin that; you'll copy defaults across.)

Didn't you have an SSRC in RTCRtpEncodingParameters?  With the
proposal as stated, it's hard to see why you might have this:
>  sequence<RTCRtpEncodingParameters> encodings;

Received on Monday, 3 November 2014 23:15:51 UTC