W3C home > Mailing lists > Public > public-webrtc@w3.org > June 2014

Re: [Bug 25977] DTMFSender should have an onerror event handler

From: Harald Alvestrand <harald@alvestrand.no>
Date: Mon, 09 Jun 2014 09:20:30 +0200
Message-ID: <5395603E.7080103@alvestrand.no>
To: public-webrtc@w3.org
On 06/05/2014 11:47 AM, bugzilla@jessica.w3.org wrote:
> https://www.w3.org/Bugs/Public/show_bug.cgi?id=25977
>
> --- Comment #2 from Kiran <kiran.guduru@samsung.com> ---
> (In reply to Justin Uberti from comment #1)
>> Shouldn't those throw an exception? Those can be easily detected
>> synchronously.
> I agree that duration and interToneGap ranges can be detected and thrown as
> exceptions.
>
> But onerror seems still required for reporting error in case of inserting
> invalid DTMF values [1], Bug: 25837.

Preferring mailing list discussion rather than bugzilla discussion:

After long discussion, we decided to let InsertDTMF ignore all 
unrecocnized characters:

"The tones parameter is treated as a series of characters. The 
characters 0 through 9, A through D, #, and * generate the associated 
DTMF tones. The characters a to d are equivalent to A to D. The 
character ',' indicates a delay of 2 seconds before processing the next 
character in the tones parameter. Unrecognized characters are ignored."

If the argument to insertDTMF is not a DOMString, TypeError will be 
thrown - this is WebIDL spec, not our spec.

What were you thinking of as a possible "invalid DTMF value", given that 
it can't be a type error and it can't be an illegal character (because 
there are  none)?


>
> [1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=25837
>
Received on Monday, 9 June 2014 07:21:07 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 15:19:40 UTC