Re: ACTION-88: Remove '?' characters from all dictionaries

On 2013-11-25 19:01, Martin Thomson wrote:
> On 25 November 2013 04:35, Adam Bergkvist <adam.bergkvist@ericsson.com> wrote:
>> Do you think it's ok if chann.maxRetransmits (the attribute on the
>> DataChannel) is null if not initialized (by the dictionary).
>
> Do you mean that you are having trouble with the defaults?
>
> Omitting maxRetransmits will result in nullptr in C++, null in Java,
> and undefined in JavaScript, unless you specify it as:
>
> dictionary blah {
>    (double or Range) maxRetransmits? = null;
> }
>
> In which case the JavaScript value changes to null.  That is
> unnecessary.  Define it as:
>
> dictionary blah {
>    (double or Range) maxRetransmits;
> }
>
> Then leave the language bindings to do their magic.  Yes, that means
> that  { maxRetransmits: null } is an invalid constraint.  That's a
> good thing.

I'm with you on the dictionary part that we don't need null there.

I'm talking about the corresponding attribute on the DataChannel object. 
The attribute from which you can read back, e.g., maxRetransmits when 
the object has been created. And the question was if you think it's ok 
for that *attribute* to be nullable.

I'll just go ahead and do the change and then we can look at the result 
and take it from there.

/Adam

Received on Tuesday, 26 November 2013 09:32:50 UTC