- From: Just a bot via GitHub <sysbot+gh@w3.org>
- Date: Fri, 20 Oct 2017 11:55:25 +0000
- To: public-webrtc-testsuite@w3.org
wpt-pr-bot has just labeled a pull request from chromium-wpt-export-bot for https://github.com/w3c/web-platform-tests as "wg-webrtc":
== Revert "WPT tests for setRemoteDescription for adding and removing tracks." ==
This reverts commit 7224091bcdc52f1d9c7f6a8eecb3e7414f29aaeb.
Reason for revert: causes tests failures on mac, e.g. https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests/builds/19421
May or may not be related to an unrelated revert that followed this original patch, https://chromium-review.googlesource.com/729719
Original change's description:
> WPT tests for setRemoteDescription for adding and removing tracks.
>
> These are behavior-driven tests, each test testing a specific behavior:
> - addTrack() with a track and no stream should fire ontrack with a
> remote track with the same ID and no streams.
> - addTrack() with a track and a stream should fire ontrack with a
> remote track and stream with matching IDs.
> - addTrack() with two tracks and a shared stream should fire ontrack
> twice with remote tracks and a shared remote stream, with matching
> IDs.
> - addTrack() with a track and two streams should fire ontrack with a
> track and two streams with matching IDs.
> - ontrack should fire before setRemoteDescription()'s promise resolves.
> - ontrack's receiver should match getReceivers().
> - removeTrack() should not result in a receiver being removed.
>
> Unlike RTCPeerConnection-ontrack.https.html, these tests do not rely on
> transceiver support. When testing a behavior like "fires an event with
> a track" the test does not test unrelated things like the event being a
> complete implementation of RTCTrackEvent with transceivers and all.
>
> In a follow-up, I will add tests for other behavior associated with the
> removal of a track, including onmute events firing and the track being
> removed from the remote streams.
>
> Bug: 774303
> Change-Id: I87d8a79d9e2e385610f749a9146b740cc649cf3f
> Reviewed-on: https://chromium-review.googlesource.com/719615
> Commit-Queue: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org>
> Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510241}
TBR=hbos@chromium.org,deadbeef@chromium.org,foolip@chromium.org
Change-Id: I8684d63e478a2ce63d760d9ec2a973b27f985729
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 774303
Reviewed-on: https://chromium-review.googlesource.com/730723
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510404}
See https://github.com/w3c/web-platform-tests/pull/7918
Received on Friday, 20 October 2017 11:55:32 UTC