Re: [webrtc-pc] Reject ICE servers with an authority component or / (#2998) from Dominique Hazael-Massieux via GitHub on 2024-09-05 (public-webrtc-logs@w3.org from September 2024)

From: Dominique Hazael-Massieux via GitHub <sysbot+gh@w3.org>
Date: Thu, 05 Sep 2024 06:57:12 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-2330750593-1725519430-sysbot+gh@w3.org>

Validating the [test stun URLs](https://github.com/dontcallmedom/web-platform-tests/blob/c515f732fc261e22d64b2d49de2a4b6f5cdc6502/webrtc/RTCConfiguration-iceServers.html#L305) against the [RFC7064 ABNF](https://github.com/dontcallmedom/rfcref/blob/main/abnf/consolidated/rfc7064.abnf), it shows the following RFC-invalid values:
```
  "stun:example\t.\norg",
  "stun:[2001::1]",
  "stun:example(&!$)*+-.;_=~☺org",
  "stun:example.net:\n",
  "stun:GOO⁠goo.com",
  "\u0000\u001b\u0004\u0012 stun:example.com\u001f \r ",
  "stun:www.foo。bar.com",
  "stun:Ｇｏ.com",
  "stun:你好你好",
  "stun:faß.ExAmPlE",
  "stun:０Ｘｃ０．０２５０．０１",
  "stun:ho\tst",
  "stun:!\"$&'()*+,-.;=_`{}~",
  "stun:\u0001\u0002\u0003\u0004\u0005\u0006\u0007\b\u000b\f\u000e\u000f\u0010\u0011\u0012\u0013\u0014\u0015\u0016\u0017\u0018\u0019\u001a\u001b\u001c\u001d\u001e\u001f^?!\"$%&'()*+,-.;=_`{}~",
  "stun:h\to\ns\rt:9\t0\n0\r0",
  "stun:1.2.3.4.",
  "192.168.257.com",
  "stun:example.net/foo",
  "stun:/example.net",
  "stun:user@example.net",
  "stun:@example.net"
```

The last 4 are addressed by this pull request.

-- 
GitHub Notification of comment by dontcallmedom
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/2998#issuecomment-2330750593 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Thursday, 5 September 2024 06:57:13 UTC